You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/15 03:13:33 UTC
[GitHub] [iotdb] SpriCoder opened a new pull request, #7322: [IOTDB-4412][MultiLeader] add `cacheWindowTimeInMs` into config.
SpriCoder opened a new pull request, #7322:
URL: https://github.com/apache/iotdb/pull/7322
See: https://issues.apache.org/jira/browse/IOTDB-4412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #7322: [IOTDB-4412][MultiLeader] add `cacheWindowTimeInMs` into config.
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #7322:
URL: https://github.com/apache/iotdb/pull/7322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #7322: [IOTDB-4412][MultiLeader] add `cacheWindowTimeInMs` into config.
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #7322:
URL: https://github.com/apache/iotdb/pull/7322#discussion_r971646872
##########
server/src/assembly/resources/conf/iotdb-datanode.properties:
##########
@@ -194,6 +194,11 @@ target_config_nodes=127.0.0.1:22277
# Datatype: long
# multi_leader_throttle_threshold_in_byte=53687091200
+# Maximum wait time of write cache in MultiLeader consensus
+# If it's a value smaller than 0, use the default value Long.MAX_VALUE.
Review Comment:
```suggestion
# If this value is less than or equal to 0, use the default value Long.MAX_VALUE.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org