You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by roshannaik <gi...@git.apache.org> on 2017/01/31 21:16:17 UTC
[GitHub] storm pull request #1908: STORM-2324 : Fix deployment failure if resources d...
GitHub user roshannaik opened a pull request:
https://github.com/apache/storm/pull/1908
STORM-2324 : Fix deployment failure if resources directory is missing in topology jar
This is same as https://github.com/apache/storm/pull/1898 ... just specific to master branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/roshannaik/storm STORM-2324m
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1908
----
commit 358dd2c379bcc1b6be168983a617029e66be4e3e
Author: Roshan Naik <ro...@hortonworks.com>
Date: 2017-01-27T00:51:37Z
STORM-2324 : Making sure toplogy deployment does not break if resources directory is missing in topology jar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1908: STORM-2324 : Fix deployment failure if resources d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1908
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1908: STORM-2324 : Fix deployment failure if resources director...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1908
+1 Given that it's identical to #1898 we don't need to wait for 24hr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1908: STORM-2324 : Fix deployment failure if resources director...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1908
+1 UT passed from local dev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1908: STORM-2324 : Fix deployment failure if resources director...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1908
Sorry missed build failure, revoking +1.
```
testSetup(org.apache.storm.daemon.supervisor.ContainerTest) Time elapsed: 0.761 sec <<< FAILURE!
org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
advancedFSOps.createSymlink(
/tmp/testing/workers/worker_id/resources,
/tmp/testing/supervisor/stormdist/test_topology/resources
);
-> at org.apache.storm.daemon.supervisor.ContainerTest.testSetup(ContainerTest.java:219)
However, there were other interactions with this mock:
-> at org.apache.storm.daemon.supervisor.Container.<init>(Container.java:135)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:305)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:312)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:313)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:314)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:317)
-> at org.apache.storm.daemon.supervisor.Container.getWorkerUser(Container.java:462)
-> at org.apache.storm.daemon.supervisor.Container.writeLogMetadata(Container.java:372)
-> at org.apache.storm.daemon.supervisor.Container.saveWorkerUser(Container.java:481)
-> at org.apache.storm.daemon.supervisor.Container.createArtifactsLink(Container.java:385)
-> at org.apache.storm.daemon.supervisor.Container.createArtifactsLink(Container.java:387)
at org.apache.storm.daemon.supervisor.ContainerTest.testSetup(ContainerTest.java:219)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---