You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by la...@apache.org on 2002/06/18 20:34:51 UTC

cvs commit: jakarta-tomcat/src/facade22/org/apache/tomcat/facade JspInterceptor.java

larryi      2002/06/18 11:34:50

  Modified:    src/facade22/org/apache/tomcat/facade JspInterceptor.java
  Log:
  Update the "depth" of the classloader URLs to get.  DependClassloader
  now includes the Context's classloader in the parent chain, so we need to
  go one parent deeper.  This should get JSP compilation working again.
  
  Revision  Changes    Path
  1.39      +2 -2      jakarta-tomcat/src/facade22/org/apache/tomcat/facade/JspInterceptor.java
  
  Index: JspInterceptor.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/facade22/org/apache/tomcat/facade/JspInterceptor.java,v
  retrieving revision 1.38
  retrieving revision 1.39
  diff -u -r1.38 -r1.39
  --- JspInterceptor.java	5 Jun 2002 03:52:50 -0000	1.38
  +++ JspInterceptor.java	18 Jun 2002 18:34:50 -0000	1.39
  @@ -934,8 +934,8 @@
           URL commonCP[];
           ClassLoader loader=ctx.getClassLoader();
           //The next will be the container classpath in trusted apps
  -        appsCP=jdkProxy.getURLs(loader,1);
  -        commonCP=jdkProxy.getURLs(loader,2);
  +        appsCP=jdkProxy.getURLs(loader,2);
  +        commonCP=jdkProxy.getURLs(loader,3);
   	if( appsCP!=null ) 
   	    cpath+=separator+extractClassPath(appsCP);
   	if( commonCP!=null ) 
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-tomcat/src/facade22/org/apache/tomcat/facade JspInterceptor.java

Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <la...@apache.org>
To: <ja...@apache.org>
Sent: Tuesday, June 18, 2002 11:34 AM
Subject: cvs commit: jakarta-tomcat/src/facade22/org/apache/tomcat/facade
JspInterceptor.java


> larryi      2002/06/18 11:34:50
>
>   Modified:    src/facade22/org/apache/tomcat/facade JspInterceptor.java
>   Log:
>   Update the "depth" of the classloader URLs to get.  DependClassloader
>   now includes the Context's classloader in the parent chain, so we need
to
>   go one parent deeper.  This should get JSP compilation working again.
>

This only works under Java 2+.  It breaks JSPs for 1.1.x, since in that case
the Context's classloader is a DCL (so Jdk11Compat will go one CL too far).
The real problem was that Jdk12Support can't un-wrap DCLs since now the
Context's classloader doesn't inherit from DCL under Java 2.

Fixing Jdk12Support is a little harder since it can't use instanceof, (and
testing the Package looks ugly).  We may end up having to "fix" Jdk11Compat
instead.



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>