You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "honeyhexin (Code Review)" <ge...@cloudera.org> on 2019/08/15 13:28:52 UTC

[kudu-CR] [test] Make the kudu-admin-test more rubust by adding AssertEventually

honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14070


Change subject: [test] Make the kudu-admin-test more rubust by adding AssertEventually
......................................................................

[test] Make the kudu-admin-test more rubust by adding AssertEventually

Sometimes it's possible the scan will not immediately retrieve the row
even though the write has already succeeded, therefore add AssertEventually
to assure the scan return the right result. It will make the test case more robust.

Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 38 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/14070/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14070

to look at the new patch set (#2).

Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually
......................................................................

[test] Make the kudu-admin-test more robust by adding AssertEventually

Sometimes it's possible the scan will not immediately retrieve the row
even though the write has already succeeded, therefore add AssertEventually
to assure the scan return the right result. It will make the test case more robust.

Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 18 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/14070/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [test] Make the kudu-admin-test more rubust by adding AssertEventually

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 )

Change subject: [test] Make the kudu-admin-test more rubust by adding AssertEventually
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG@9
PS1, Line 9: Sometimes it's possible the scan will not immediately retrieve the row
           : even though the write has already succeeded, therefore add AssertEventually
           : to assure the scan return the right result. It will make the test case more robust.
> Agreed when the scan follows a drop range partition, but we don't need it e
+1

Since CountTableRows() use LEADER_ONLY scan mode and the prior write operation succeeds, the rows should be there.  Adding ASSERT_EVENTUALLY in such cases would mask a bug (if any appears).



-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 15 Aug 2019 16:40:10 +0000
Gerrit-HasComments: Yes

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14070 )

Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually
......................................................................

[test] Make the kudu-admin-test more robust by adding AssertEventually

Sometimes it's possible the scan will not immediately retrieve the row
even though the write has already succeeded, therefore add AssertEventually
to assure the scan return the right result. It will make the test case more robust.

Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Reviewed-on: http://gerrit.cloudera.org:8080/14070
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 18 insertions(+), 9 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 4
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14070

to look at the new patch set (#3).

Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually
......................................................................

[test] Make the kudu-admin-test more robust by adding AssertEventually

Sometimes it's possible the scan will not immediately retrieve the row
even though the write has already succeeded, therefore add AssertEventually
to assure the scan return the right result. It will make the test case more robust.

Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 18 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/14070/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 3
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 )

Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 3
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 23:54:41 +0000
Gerrit-HasComments: No

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 )

Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG@7
PS1, Line 7: robust
> robust
Done


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2394
PS1, Line 2394:   ASSERT_OK(client_->OpenTable(kTableId, &table));
> Or here.
Done


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2434
PS1, Line 2434: }
> Or here.
Done


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2535
PS1, Line 2535:     // which will return error in lambda as we expect.
> Or here.
Done


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2564
PS1, Line 2564:     ASSERT_EVENTUALLY([&]() {
> Or here.
Done


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2847
PS1, Line 2847:     "drop_range_partition",
> Don't need it here.
Oops, I made a mistake. I will fix it.



-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 22:25:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] [test] Make the kudu-admin-test more rubust by adding AssertEventually

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 )

Change subject: [test] Make the kudu-admin-test more rubust by adding AssertEventually
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG@7
PS1, Line 7: rubust
robust


http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG@9
PS1, Line 9: Sometimes it's possible the scan will not immediately retrieve the row
           : even though the write has already succeeded, therefore add AssertEventually
           : to assure the scan return the right result. It will make the test case more robust.
Agreed when the scan follows a drop range partition, but we don't need it everywhere. For example, after a bunch of inserts with a flush, the rows are guaranteed to be read by the next scan.

I've left comments in the code with the locations of AssertEventually calls that we don't need.


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2394
PS1, Line 2394:   ASSERT_EVENTUALLY([&]() {
Or here.


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2434
PS1, Line 2434:   ASSERT_EVENTUALLY([&]() {
Or here.


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2535
PS1, Line 2535:     ASSERT_EVENTUALLY([&]() {
Or here.


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2564
PS1, Line 2564:     ASSERT_EVENTUALLY([&]() {
Or here.


http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2847
PS1, Line 2847:   ASSERT_EVENTUALLY([&]() {
Don't need it here.



-- 
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 15 Aug 2019 16:34:05 +0000
Gerrit-HasComments: Yes