You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2025/01/01 09:00:58 UTC

[PR] [CELEBORN-1774][FOLLOWUP] Change celeborn..io.mode optional to explain default behavior in description [celeborn]

SteNicholas opened a new pull request, #3044:
URL: https://github.com/apache/celeborn/pull/3044

   ### What changes were proposed in this pull request?
   
   Change `celeborn.<module>.io.mode` optional to explain default behavior in description.
   
   ### Why are the changes needed?
   
   The default value of `celeborn.<module>.io.mode` in document could be changed by whether epoll mode is available for different os. Therefore, `celeborn.<module>.io.mode` should be changed to optional and explained the default behavior in description of option.
   
   Follow up https://github.com/apache/celeborn/pull/3039#discussion_r1899340272.
   
   ### Does this PR introduce _any_ user-facing change?
   
   `celeborn.<module>.io.mode` is optional and explains default behavior in description.
   
   ### How was this patch tested?
   
   CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1774][FOLLOWUP] Change celeborn..io.mode optional to explain default behavior in description [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3044:
URL: https://github.com/apache/celeborn/pull/3044#issuecomment-2567759840

   Merged to main(v0.6.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1774][FOLLOWUP] Change celeborn..io.mode optional to explain default behavior in description [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3044: [CELEBORN-1774][FOLLOWUP] Change celeborn.<module>.io.mode optional to explain default behavior in description
URL: https://github.com/apache/celeborn/pull/3044


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org