[jira] [Comment Edited] (FELIX-4811) Optimize ConfigurationManager#listConfigurations

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340880#comment-14340880 ] 

Guillaume Nodet edited comment on FELIX-4811 at 2/27/15 9:58 PM:
-----------------------------------------------------------------

Possible patch at
  https://github.com/gnodet/felix/commit/d6bf5ae7a82094feb367f223a03da9644b3d996d


was (Author: gnt):
Possible patch at
  https://github.com/gnodet/felix/commit/a0926452afc347ff331b6a3969d1d81a970c5759

> Optimize ConfigurationManager#listConfigurations
> ------------------------------------------------
>
>                 Key: FELIX-4811
>                 URL: https://issues.apache.org/jira/browse/FELIX-4811
>             Project: Felix
>          Issue Type: Improvement
>          Components: Configuration Admin
>    Affects Versions: configadmin-1.8.0
>            Reporter: Guillaume Nodet
>         Attachments: yourkit.png
>
>
> The ConfigurationManager#listConfigurations is far from optimal.
> It iterates on all configurations, thereby creating a copy of the properties for each configuration.   Then, for each configuration, filter#match() is called, which itself create a case insentive copy of the properties for matching.
> If you have quite a lot of configurations and quite a lof of SCR components, it can be quite time consuming.
> Attached is a YourKit profile view which shows that 90% of the time is spent into copying properties for nothing. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)