[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1358: Add dag

[GitBox <gi...@apache.org>]

TeslaCN commented on a change in pull request #1358:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1358#discussion_r468307674



##########
File path: elasticjob-infra/elasticjob-tracing/elasticjob-tracing-api/src/test/java/org/apache/shardingsphere/elasticjob/tracing/fixture/TestTracingListener.java
##########
@@ -41,7 +42,13 @@ public void listen(final JobExecutionEvent jobExecutionEvent) {
     public void listen(final JobStatusTraceEvent jobStatusTraceEvent) {
         jobEventCaller.call();
     }
-    
+
+    @Override
+    public void listen(DagJobExecutionEvent dagJobExecutionEvent) {

Review comment:
       Parameter dagJobExecutionEvent should be final.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org