[GitHub] [pulsar-client-go] flowchartsman commented on a change in pull request #604: User-defined metric cardinality

[GitBox <gi...@apache.org>]

flowchartsman commented on a change in pull request #604:
URL: https://github.com/apache/pulsar-client-go/pull/604#discussion_r697892929



##########
File path: pulsar/internal/metrics.go
##########
@@ -21,9 +21,8 @@ import (
 	"github.com/prometheus/client_golang/prometheus"
 )
 
-var topicLabelNames = []string{"pulsar_tenant", "pulsar_namespace", "topic"}
-
 type Metrics struct {
+	metricsLevel      int

Review comment:
       It might, but that’s definitely a hack around some layout problems. But there probably aren’t any half-measures there, save an awkward new package, so I guess that’s a ticket for another day. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org