You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/28 05:48:05 UTC

[GitHub] [yunikorn-core] chungen0126 commented on a change in pull request #384: [YUNIKORN-790] Implement MaxApplications enforcement

chungen0126 commented on a change in pull request #384:
URL: https://github.com/apache/yunikorn-core/pull/384#discussion_r836071690



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1264,6 +1264,9 @@ func (sa *Application) AddAllocation(info *Allocation) {
 // Add the Allocation to the application
 // No locking must be called while holding the lock
 func (sa *Application) addAllocationInternal(info *Allocation) {

Review comment:
       I add another condition to make sure it will still allocate the running application. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org