You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Xiao Kang (JIRA)" <ji...@apache.org> on 2010/04/06 03:56:27 UTC
[jira] Created: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
the first optimization: ZlibCompressor does not fully utilize the buffer
------------------------------------------------------------------------
Key: HADOOP-6683
URL: https://issues.apache.org/jira/browse/HADOOP-6683
Project: Hadoop Common
Issue Type: Sub-task
Components: io
Affects Versions: 0.20.2
Reporter: Xiao Kang
Thanks for Hong Tang's advice.
Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Kang Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924803#action_12924803 ]
Kang Xiao commented on HADOOP-6683:
-----------------------------------
This optimization for zlibcompressor has been deployed in our cluster and works as expected.
Is there any more work needed for this patch to be reviewed or resolved?
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Kang Xiao
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928517#action_12928517 ]
Hadoop QA commented on HADOOP-6683:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12440826/ZlibCompressor.java.patch
against trunk revision 1031422.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/41//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/41//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/41//console
This message is automatically generated.
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Kang Xiao
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Xiao Kang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Kang updated HADOOP-6683:
------------------------------
Release Note: Improve the buffer utilization of ZlibCompressor to avoid invoking a JNI per write request.
Status: Patch Available (was: Open)
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Xiao Kang
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Xiao Kang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855353#action_12855353 ]
Xiao Kang commented on HADOOP-6683:
-----------------------------------
This patch does not add any new function and he test case src/test/org/apache/hadoop/core/io/compress/TestCodec.java has covered this patch.
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Xiao Kang
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Xiao Kang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Kang updated HADOOP-6683:
------------------------------
Attachment: ZlibCompressor.java.patch
Patch attached.
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Xiao Kang
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855255#action_12855255 ]
Hadoop QA commented on HADOOP-6683:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12440826/ZlibCompressor.java.patch
against trunk revision 932115.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/452/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/452/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/452/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/452/console
This message is automatically generated.
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Xiao Kang
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Xiao Kang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854316#action_12854316 ]
Xiao Kang commented on HADOOP-6683:
-----------------------------------
A comparision test was performed on a 1.8GB web log file. The result is as follows:
|| read file buffer size || write to compress stream buffer size || old time(secs) || new time(secs) || decrease % ||
|65536| 100 |67| 49| 26.8%|
|65536| 200| 56.5| 46.5| 17.7%|
|65536| 400| 51.5| 45| 12.6%|
|65536| 800| 48.5| 44.5| 8.2%|
|65536| 1024| 46.8| 44.2| 9.8%|
|65536| 4096| 45| 43.5| 3.3%|
|65536| 65536| 44.6| 43.2| 3.1%|
Is there any standard benchmark for compression suitable for this case?
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Xiao Kang
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6683) the first optimization:
ZlibCompressor does not fully utilize the buffer
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854054#action_12854054 ]
Todd Lipcon commented on HADOOP-6683:
-------------------------------------
Hi Xiao,
Do you have any benchmarks on this? Would be interesting to see.
-Todd
> the first optimization: ZlibCompressor does not fully utilize the buffer
> ------------------------------------------------------------------------
>
> Key: HADOOP-6683
> URL: https://issues.apache.org/jira/browse/HADOOP-6683
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.20.2
> Reporter: Xiao Kang
> Attachments: ZlibCompressor.java.patch
>
>
> Thanks for Hong Tang's advice.
> Sub task created for the first optimization. HADOOP-6662 closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.