You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by benchristel <gi...@git.apache.org> on 2018/07/12 21:06:20 UTC
[GitHub] incubator-hawq pull request #1381: Remove autogeneration of version number f...
GitHub user benchristel opened a pull request:
https://github.com/apache/incubator-hawq/pull/1381
Remove autogeneration of version number from pxf/build.gradle
**NOT READY TO MERGE**. The purpose of this PR is to solicit feedback on our approach. We'll need to do more work to get the hardcoded version number out of this code.
This enables us to use IntelliJ's code navigation and refactoring
features. Previously, IntelliJ would navigate to / refactor the
generated files rather than the source files since the generated files
were the ones that actually got compiled.
We also upgraded Gradle to 3.0 because we suspected IntelliJ might not have good support for older Gradle versions. We may want to revert the change to the Gradle version if it wasn't the culprit.
Co-authored-by: Lav Jain <lj...@pivotal.io>
Co-authored-by: Ben Christel <bc...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain/incubator-hawq support-intellij-refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1381
----
commit c3ba4a5312283cca3bf820a312da5428458be704
Author: Francisco Guerrero <ag...@...>
Date: 2018-07-12T20:59:55Z
Remove autogeneration of version number from pxf/build.gradle
This enables us to use IntelliJ's code navigation and refactoring
features. Previously, IntelliJ would navigate to / refactor the
generated files rather than the source files since the generated files
were the ones that actually got compiled.
Co-authored-by: Francisco Guerrero <ag...@pivotal.io>
Co-authored-by: Ben Christel <bc...@pivotal.io>
----
---
[GitHub] incubator-hawq issue #1381: Remove autogeneration of version number from pxf...
Posted by benchristel <gi...@git.apache.org>.
Github user benchristel commented on the issue:
https://github.com/apache/incubator-hawq/pull/1381
Closing this for now, as these changes are out of date and the issue hasn't been a pain point for us recently.
---
[GitHub] incubator-hawq pull request #1381: Remove autogeneration of version number f...
Posted by benchristel <gi...@git.apache.org>.
Github user benchristel closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1381
---
[GitHub] incubator-hawq issue #1381: Remove autogeneration of version number from pxf...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on the issue:
https://github.com/apache/incubator-hawq/pull/1381
Until recently the version number was hardcoded in the code. generatedSources task does seem to be more pain than benefit. I'm fine with merging this change even in the mean time until we figure out an alternate means of fetching the version programatically
---
[GitHub] incubator-hawq pull request #1381: Remove autogeneration of version number f...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1381#discussion_r202179965
--- Diff: pxf/gradle/wrapper/gradle-wrapper.properties ---
@@ -1,23 +1,6 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-#Wed Aug 05 16:07:21 PDT 2015
+#Mon Jul 09 15:02:34 PDT 2018
--- End diff --
lack of license will trip license checker, unless you add this file to exclusion list, even better to preserve the license.
---