You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/28 17:21:29 UTC
[GitHub] [airflow] dimberman opened a new pull request #11924: Clean directories for upgrade checks
dimberman opened a new pull request #11924:
URL: https://github.com/apache/airflow/pull/11924
As we plan to add many more upgrade checks soon,
this PR allows for compartmentalization of checks
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11924: Clean directories for upgrade checks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11924:
URL: https://github.com/apache/airflow/pull/11924#issuecomment-718811376
[The Workflow run](https://github.com/apache/airflow/actions/runs/336074105) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11924: Clean directories for upgrade checks
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11924:
URL: https://github.com/apache/airflow/pull/11924#discussion_r513742404
##########
File path: tests/upgrade/rules/test_base_rule.py
##########
@@ -16,7 +16,7 @@
# under the License.
from airflow.upgrade.rules import get_rules
-from airflow.upgrade.rules.conn_type_is_not_nullable import ConnTypeIsNotNullableRule
+from airflow.upgrade.rules.conn_id.conn_type_is_not_nullable import ConnTypeIsNotNullableRule
Review comment:
```suggestion
from airflow.upgrade.rules.db.conn_type_is_not_nullable import ConnTypeIsNotNullableRule
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11924: Clean directories for upgrade checks
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11924:
URL: https://github.com/apache/airflow/pull/11924#issuecomment-721079789
@dimberman please target `v1-10-stable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11924: Clean directories for upgrade checks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11924:
URL: https://github.com/apache/airflow/pull/11924#issuecomment-718114084
[The Workflow run](https://github.com/apache/airflow/actions/runs/334143298) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11924: Clean directories for upgrade checks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11924:
URL: https://github.com/apache/airflow/pull/11924#issuecomment-718198692
[The Workflow run](https://github.com/apache/airflow/actions/runs/334465312) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed pull request #11924: Clean directories for upgrade checks
Posted by GitBox <gi...@apache.org>.
dimberman closed pull request #11924:
URL: https://github.com/apache/airflow/pull/11924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org