You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Michael Bien <mb...@gmail.com> on 2022/08/15 13:18:03 UTC
committer/pmc opinions needed for PR which is in limbo for NB 15 inclusion
Hello devs,
we got a last minute PR which would need more reviews till tomorrow so
that it can be potentially merged to the (likely) last RC of NetBeans 15.
NB 15 is in the RC phase which means we only merge bugfixes (but
sometimes there are exceptions if its discussed here, for example if a
new javac version overlaps with the RC phase). This PR is fixes a
"performance defect" and breaks up m*m*n complicity into m*n. It is
debatable if it counts as a bug or not. In my opinion there is not much
of a difference between a NPE and a completion window which doesn't
appear for 10s. The fix is also fairly trivial as you will see.
So please review for correctness first, and if you review mention in the
comment if you want to see this PR for 15 or 16.
https://github.com/apache/netbeans/pull/4502
(see link to issue for all the graphs and more info)
thanks,
michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: committer/pmc opinions needed for PR which is in limbo for NB 15 inclusion
Posted by Neil C Smith <ne...@apache.org>.
On Mon, 15 Aug 2022 at 14:21, Michael Bien <mb...@gmail.com> wrote:
> we got a last minute PR which would need more reviews till tomorrow so
> that it can be potentially merged to the (likely) last RC of NetBeans 15.
Well, it's not in limbo now, it's in delivery. Will be in rc4.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Re: committer/pmc opinions needed for PR which is in limbo for NB 15 inclusion
Posted by Eric Bresie <eb...@gmail.com>.
I’m not an expert or PMC per say but…
From code perspective it seem simple enough and looks reasonable.
It sounds like this may really be a “part 1” with a follow up issue to come is that right?
Eric Bresie
Ebresie@gmail.com (mailto:Ebresie@gmail.com)
> On August 18, 2022 at 11:04:38 AM CDT, László Kishalmi <laszlo.kishalmi@gmail.com (mailto:laszlo.kishalmi@gmail.com)> wrote:
> I was about to check the PR, could not find the time for that though.
>
> I'm sorry
>
> On Thu, Aug 18, 2022 at 7:02 AM Michael Bien <mbien42@gmail.com (mailto:mbien42@gmail.com)> wrote:
>
> > On 18.08.22 12:09, Neil C Smith wrote:
> > > On Mon, 15 Aug 2022 at 14:21, Michael Bien <mbien42@gmail.com (mailto:mbien42@gmail.com)> wrote:
> > > > So please review for correctness first, and if you review mention in the
> > > > comment if you want to see this PR for 15 or 16.
> > > This PR is now in rc4.
> > >
> > > From a releases perspective, can I add that we really need correctness
> > > and suitability of base branch (eg. delivery) to be reviewed together.
> > > Any reviewer can, and should if necessary, veto a merge to delivery
> > > even if they're 100% happy with the code being merged to master.
> > >
> > > While I somewhat shared Matthias' reservations about merging for rc4,
> > > as I said on the PR it would be merged if no-one else vetoed. It's
> > > not the job of people doing release builds to "clear" things.
> >
> > agreed. That was essentially the reason for the mail, to generate a
> > clear NO or YES for NB15 integration once more reviews are available.
> > Unfortunately nobody said anything :(
> >
> > (in my mind a review approval with the comment "for NB16" would veto
> > NB15 merge, a change request would "veto" the entire PR etc)
> >
> > -mbien
> >
> > > Best wishes,
> > >
> > > Neil
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org (mailto:dev-unsubscribe@netbeans.apache.org)
> > > For additional commands, e-mail: dev-help@netbeans.apache.org (mailto:dev-help@netbeans.apache.org)
> > >
> > > For further information about the NetBeans mailing lists, visit:
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > >
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org (mailto:dev-unsubscribe@netbeans.apache.org)
> > For additional commands, e-mail: dev-help@netbeans.apache.org (mailto:dev-help@netbeans.apache.org)
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
> >
Re: committer/pmc opinions needed for PR which is in limbo for NB 15 inclusion
Posted by László Kishalmi <la...@gmail.com>.
I was about to check the PR, could not find the time for that though.
I'm sorry
On Thu, Aug 18, 2022 at 7:02 AM Michael Bien <mb...@gmail.com> wrote:
> On 18.08.22 12:09, Neil C Smith wrote:
> > On Mon, 15 Aug 2022 at 14:21, Michael Bien <mb...@gmail.com> wrote:
> >> So please review for correctness first, and if you review mention in the
> >> comment if you want to see this PR for 15 or 16.
> > This PR is now in rc4.
> >
> > From a releases perspective, can I add that we really need correctness
> > and suitability of base branch (eg. delivery) to be reviewed together.
> > Any reviewer can, and should if necessary, veto a merge to delivery
> > even if they're 100% happy with the code being merged to master.
> >
> > While I somewhat shared Matthias' reservations about merging for rc4,
> > as I said on the PR it would be merged if no-one else vetoed. It's
> > not the job of people doing release builds to "clear" things.
>
> agreed. That was essentially the reason for the mail, to generate a
> clear NO or YES for NB15 integration once more reviews are available.
> Unfortunately nobody said anything :(
>
> (in my mind a review approval with the comment "for NB16" would veto
> NB15 merge, a change request would "veto" the entire PR etc)
>
> -mbien
>
> > Best wishes,
> >
> > Neil
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> > For additional commands, e-mail: dev-help@netbeans.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: committer/pmc opinions needed for PR which is in limbo for NB 15 inclusion
Posted by Michael Bien <mb...@gmail.com>.
On 18.08.22 12:09, Neil C Smith wrote:
> On Mon, 15 Aug 2022 at 14:21, Michael Bien <mb...@gmail.com> wrote:
>> So please review for correctness first, and if you review mention in the
>> comment if you want to see this PR for 15 or 16.
> This PR is now in rc4.
>
> From a releases perspective, can I add that we really need correctness
> and suitability of base branch (eg. delivery) to be reviewed together.
> Any reviewer can, and should if necessary, veto a merge to delivery
> even if they're 100% happy with the code being merged to master.
>
> While I somewhat shared Matthias' reservations about merging for rc4,
> as I said on the PR it would be merged if no-one else vetoed. It's
> not the job of people doing release builds to "clear" things.
agreed. That was essentially the reason for the mail, to generate a
clear NO or YES for NB15 integration once more reviews are available.
Unfortunately nobody said anything :(
(in my mind a review approval with the comment "for NB16" would veto
NB15 merge, a change request would "veto" the entire PR etc)
-mbien
> Best wishes,
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: committer/pmc opinions needed for PR which is in limbo for NB 15 inclusion
Posted by Neil C Smith <ne...@apache.org>.
On Mon, 15 Aug 2022 at 14:21, Michael Bien <mb...@gmail.com> wrote:
> So please review for correctness first, and if you review mention in the
> comment if you want to see this PR for 15 or 16.
This PR is now in rc4.
From a releases perspective, can I add that we really need correctness
and suitability of base branch (eg. delivery) to be reviewed together.
Any reviewer can, and should if necessary, veto a merge to delivery
even if they're 100% happy with the code being merged to master.
While I somewhat shared Matthias' reservations about merging for rc4,
as I said on the PR it would be merged if no-one else vetoed. It's
not the job of people doing release builds to "clear" things.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists