You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/05/16 15:11:01 UTC
[GitHub] [metron] sardell edited a comment on issue #1380: METRON-1253:
Manual pasting of timestamps into the timestamp picker
sardell edited a comment on issue #1380: METRON-1253: Manual pasting of timestamps into the timestamp picker
URL: https://github.com/apache/metron/pull/1380#issuecomment-493107444
@ruffle1986 This looks good to me, but I do want to bring up one thing that I noticed that's existed before but is even more pronounced now that we can enter the timestamp manually.
In the date picker template, there is a click handler that toggles the menu on the input element. I think if a user is manually entering a timestamp, they won't need to see a calendar. In addition, let's say I want to changed the default populated 'now' value to my own custom timestamp. I would double click on the field in order to highlight the 'now' value and replace it with my own value. This quickly opens and closes the calendar. When I go to click on the Apply button, the calendar appears again. I included a gif below to show what I'm talking about.
I think that instead of having a click handler on the input, we should maybe have it on the calendar icon. That way, the date picker behaves more like this one from Angular Material.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services