You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dion Gillard <di...@gmail.com> on 2004/07/04 16:20:21 UTC
1.0 branch and dist plugin
I'm having problems with maven:get in the latest builds of the 1.0 branch.
In the NSIS plugin I have this:
<maven:get var="maven.dist.bin.assembly.dir"
plugin="maven-dist-plugin" property="maven.dist.bin.assembly.dir"/>
And it comes back blank.
Thinking it was the variable, I tried:
<maven:get var="distDir" plugin="maven-dist-plugin"
property="maven.dist.dir"/>
Still no luck.
Also, running maven dist by itself works ok, but putting it as a
pre-req for a plugin goal fails miserably with
INTERNAL ERROR
Reference made to goal 'dist' which has no definition.
Any ideas?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: 1.0 branch and dist plugin
Posted by Brett Porter <br...@apache.org>.
Fixed in CVS. <maven:get /> and <maven:set/> now load the plugin if necessary.
I'll add a test on the way in for :set and then post some more info - looks like
we can ditch those stupid dependency handles though.
The fix is something like the last straw the PluginManager camel's back can
take, but it's still holding :)
PluginManager is now most definitely not thread safe if it ever was.
Cheers,
Brett
Quoting Brett Porter <br...@apache.org>:
> Bizarre... I'll take a look tonight.
>
> Quoting Dion Gillard <di...@gmail.com>:
>
> > On Mon, 5 Jul 2004 14:54:38 +1000, Dion Gillard <di...@gmail.com>
> > wrote:
> > > I'll try adding a prereq of dist:build-setup
> >
> > Same sort of failure:
> >
> > Tag library requested that is not present: 'dist' in plugin:
> > 'maven-nsis-plugin-1.1-SNAPSHOT'
> > INTERNAL ERROR
> > Reference made to goal 'dist:build-setup' which has no definition.
> > --
> > http://www.multitask.com.au/people/dion/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: 1.0 branch and dist plugin
Posted by Brett Porter <br...@apache.org>.
Bizarre... I'll take a look tonight.
Quoting Dion Gillard <di...@gmail.com>:
> On Mon, 5 Jul 2004 14:54:38 +1000, Dion Gillard <di...@gmail.com>
> wrote:
> > I'll try adding a prereq of dist:build-setup
>
> Same sort of failure:
>
> Tag library requested that is not present: 'dist' in plugin:
> 'maven-nsis-plugin-1.1-SNAPSHOT'
> INTERNAL ERROR
> Reference made to goal 'dist:build-setup' which has no definition.
> --
> http://www.multitask.com.au/people/dion/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: 1.0 branch and dist plugin
Posted by Dion Gillard <di...@gmail.com>.
On Mon, 5 Jul 2004 14:54:38 +1000, Dion Gillard <di...@gmail.com> wrote:
> I'll try adding a prereq of dist:build-setup
Same sort of failure:
Tag library requested that is not present: 'dist' in plugin:
'maven-nsis-plugin-1.1-SNAPSHOT'
INTERNAL ERROR
Reference made to goal 'dist:build-setup' which has no definition.
--
http://www.multitask.com.au/people/dion/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: 1.0 branch and dist plugin
Posted by Dion Gillard <di...@gmail.com>.
On Mon, 5 Jul 2004 11:18:26 +1000, Brett Porter <br...@apache.org> wrote:
> Quoting Dion Gillard <di...@gmail.com>:
>
> > I'm having problems with maven:get in the latest builds of the 1.0 branch.
> >
> > In the NSIS plugin I have this:
> >
> > <maven:get var="maven.dist.bin.assembly.dir"
> > plugin="maven-dist-plugin" property="maven.dist.bin.assembly.dir"/>
> >
> > And it comes back blank.
>
> This stuff has always been flaky. It depends on the plugin already being loaded.
> The "documented" fashion of doing so is a taglib dependency handle (see
> eclipse's use of test/cactus). Using a pregoal will also work.
As far as I can tell from maven -X, using xmlns:dist="dist" doesn't
load the dist plugin.
> Clear your plugin cache and try again... try depending on dist:dist... that's
> all I can think of off the top of my head.
I cleared the cache (~/.maven/plugins and ~/.maven/cache) and it's still blank.
Can you try this on your installation?
Just checkout and install the latest nsis plugin, and then do 'maven
nsis' from the maven source directory.
On my machine it barfs because maven:get returns a blank value, with:
'maven.dist.bin.assembly.dir' must be specified. It is the directory
containing files to be placed in the installer
I'll try adding a prereq of dist:build-setup
--
http://www.multitask.com.au/people/dion/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: 1.0 branch and dist plugin
Posted by Brett Porter <br...@apache.org>.
Quoting Dion Gillard <di...@gmail.com>:
> Given Jason's comments last week, I'm trying not to put preGoals in plugins.
Yep, that's a good thing. I probably meant prereq though - if there is a goal
(like the :init stuff) you can prereq on that'll work (eg war:load was used for
this), but the taglib stuff is definitely preferable as it is slightly less gross.
> > Incidentially, I saw the bug you filed against dist + touchstone. Maven
> doesn't
> > use dist to build releases at the moment, so I'm not sure fix for 1.0 is
> > appropriate.
>
> I'm more worried that dist is exposing an issue in Maven.
Touchstone is fairly sensitive to the context it is run from, so it may break
run under certain circumstances. Hooking it onto test:test wasn't a great idea
but at least it gets run :)
Given that we haven't had any other reports of that type of issue recently, I'm
not particularly worried about it being a big problem, so can be pushed behind
1.0 IMO.
Cheers,
Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: 1.0 branch and dist plugin
Posted by Dion Gillard <di...@gmail.com>.
On Mon, 5 Jul 2004 11:18:26 +1000, Brett Porter <br...@apache.org> wrote:
> Quoting Dion Gillard <di...@gmail.com>:
>
> This stuff has always been flaky. It depends on the plugin already being loaded.
> The "documented" fashion of doing so is a taglib dependency handle (see
> eclipse's use of test/cactus). Using a pregoal will also work.
Given Jason's comments last week, I'm trying not to put preGoals in plugins.
> > Also, running maven dist by itself works ok, but putting it as a
> > pre-req for a plugin goal fails miserably with
> >
> > INTERNAL ERROR
> > Reference made to goal 'dist' which has no definition.
>
> Clear your plugin cache and try again... try depending on dist:dist... that's
> all I can think of off the top of my head.
Will do.
> Incidentially, I saw the bug you filed against dist + touchstone. Maven doesn't
> use dist to build releases at the moment, so I'm not sure fix for 1.0 is
> appropriate.
I'm more worried that dist is exposing an issue in Maven.
--
http://www.multitask.com.au/people/dion/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: 1.0 branch and dist plugin
Posted by Brett Porter <br...@apache.org>.
Quoting Dion Gillard <di...@gmail.com>:
> I'm having problems with maven:get in the latest builds of the 1.0 branch.
>
> In the NSIS plugin I have this:
>
> <maven:get var="maven.dist.bin.assembly.dir"
> plugin="maven-dist-plugin" property="maven.dist.bin.assembly.dir"/>
>
> And it comes back blank.
This stuff has always been flaky. It depends on the plugin already being loaded.
The "documented" fashion of doing so is a taglib dependency handle (see
eclipse's use of test/cactus). Using a pregoal will also work.
> Also, running maven dist by itself works ok, but putting it as a
> pre-req for a plugin goal fails miserably with
>
> INTERNAL ERROR
> Reference made to goal 'dist' which has no definition.
Clear your plugin cache and try again... try depending on dist:dist... that's
all I can think of off the top of my head.
Incidentially, I saw the bug you filed against dist + touchstone. Maven doesn't
use dist to build releases at the moment, so I'm not sure fix for 1.0 is
appropriate.
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org