You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/18 14:15:07 UTC
[GitHub] [ozone] symious opened a new pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
symious opened a new pull request #1817:
URL: https://github.com/apache/ozone/pull/1817
…key creation with copy
## What changes were proposed in this pull request?
- Add the header check of copy-source-if-(un)modified-since.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1997
## How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-768143159
> I used the error message from AWS,
Yes, I just learned it. It's fine to keep the current message to mimic the behavior of AWS.
Just FYI: You can create command line compatibility test (Test which executes AWS CLI and checks results) with modifying this file:
https://github.com/apache/ozone/blob/master/hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
(And executing `./test.sh` from `compose/ozone` folder from the build).
It's more like a good to have, not a must-have (IMHO), but if you are interested, you can check, and create other Jira/patch with improving acceptance tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-768360769
Fixed the patch to check the date from the header.
Will raise another commit for the robot test. Not familiar with the robot test, need some time to work on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-767965019
@elek Thanks for the comment.
I think I was doing the test with s3api too, but I was testing with Long only. Will update the patch to support String also.
For the error message, I used the error message from AWS, I will add more details in the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-764648739
@elek Could you help to review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-764648739
@elek Could you help to review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-768146670
Sure, thanks for the suggestions.
I'm a little confused here, I have tried different typs of date format with was s3api, like "01-12-2020", "13-01-2020" and Long type timestamp, I found AWS is handling them all well.
I am trying to use parseDate from common-lang3 which can parse date according to a list of format, but seems a little hard to list all possible DateFormat, do you have any suggestions on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1817:
URL: https://github.com/apache/ozone/pull/1817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-769021980
@elek The robot script is updated, could you have a check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-775243133
My pleasure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious edited a comment on pull request #1817: HDDS-1997. Support copy-source-if-(un)modified-since headers for MPU …
Posted by GitBox <gi...@apache.org>.
symious edited a comment on pull request #1817:
URL: https://github.com/apache/ozone/pull/1817#issuecomment-768146670
Sure, thanks for the suggestions.
~~I'm a little confused here, I have tried different typs of date format with was s3api, like "01-12-2020", "13-01-2020" and Long type timestamp, I found AWS is handling them all well.
I am trying to use parseDate from common-lang3 which can parse date according to a list of format, but seems a little hard to list all possible DateFormat, do you have any suggestions on this?~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org