You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/06 15:43:24 UTC
[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
KishaniKandasamy opened a new pull request #333:
URL: https://github.com/apache/apisix-website/pull/333
Fixes: #325
Changes:
update run-ingress-apisix-on-amazon-eks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-834678815
> @KishaniKandasamy Sorry I provide the wrong URL, it should be `http://apisix.apache.org/docs/ingress-controller/deployments/aws/`. Do you mind fixing it again 😿
No problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#discussion_r628070382
##########
File path: website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md
##########
@@ -16,7 +16,7 @@ authorImageURL: "https://avatars0.githubusercontent.com/u/10428333?s=60&v=4"
> - https://github.com/apache/apisix-helm-chart
> - https://github.com/apache/apisix-ingress-controller
-This post is based on [Install Ingress APISIX on Amazon EKS](https://github.com/apache/apisix-ingress-controller/blob/master/docs/deployments/aws.md).
+This post is based on [Install Ingress APISIX on Amazon EKS](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/aws.md).
Review comment:
might be better to use the website link
http://apisix.incubator.apache.org/docs/ingress-controller/deployments/aws/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] tokers commented on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833994810
@KishaniKandasamy Do the other documentations (like ACK, TKE, GKE) also have these problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* ready!
Built with commit d67bf8d5d51103bb79590bec6c21a1e9eef1a240
https://deploy-preview-333--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* ready!
Built with commit 59714ad0d7ad2e7a3e7c4812b5c77be9a60081e4
https://deploy-preview-333--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* processing.
Building with commit 15031582867a2f4d6adc268d15ffe6e7119e7dd0
https://app.netlify.com/sites/apisix/deploys/609623d6443de200081de3bf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* ready!
Built with commit b2dc50eb5aa84e40aefa1fcc5db04691d3a5b3f1
https://deploy-preview-333--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #333:
URL: https://github.com/apache/apisix-website/pull/333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-834588077
@KishaniKandasamy Sorry I provide the wrong URL, it should be `http://apisix.apache.org/docs/ingress-controller/deployments/aws/`. Do you mind fixing it again 😿
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#discussion_r628465454
##########
File path: website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md
##########
@@ -65,7 +65,7 @@ kubectl get service apisix-gateway \
Another thing should be concerned that the `allow.ipList` field should be customized according to the [EKS CIDR Ranges](https://amazonaws-china.com/premiumsupport/knowledge-center/eks-multiple-cidr-ranges/) in your EKS cluster, so that the apisix-ingress-controller can be authorized by Apache APISIX (for the resources pushing).
-See value.yaml](https://github.com/apache/apisix-helm-chart/blob/master/chart/apisix/values.yaml) to learn all the configuration items if you have other requirements.
+See value.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml) to learn all the configuration items if you have other requirements.
Review comment:
Missing a bracket here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* processing.
Building with commit d67bf8d5d51103bb79590bec6c21a1e9eef1a240
https://app.netlify.com/sites/apisix/deploys/6095484c08663b0008a6853c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-834050062
> @KishaniKandasamy Do the other documentations (like ACK, TKE, GKE) also have these problems?
No.
Just checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] tokers commented on a change in pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#discussion_r628662500
##########
File path: website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md
##########
@@ -16,7 +16,7 @@ authorImageURL: "https://avatars0.githubusercontent.com/u/10428333?s=60&v=4"
> - https://github.com/apache/apisix-helm-chart
> - https://github.com/apache/apisix-ingress-controller
-This post is based on [Install Ingress APISIX on Amazon EKS](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/aws.md).
+This post is based on [Install Ingress APISIX on Amazon EKS](http://apisix.incubator.apache.org/docs/ingress-controller/deployments/aws/).
Review comment:
```suggestion
This post is based on [Install Ingress APISIX on Amazon EKS](https://apisix.apache.org/docs/ingress-controller/deployments/aws/).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* processing.
Building with commit 59714ad0d7ad2e7a3e7c4812b5c77be9a60081e4
https://app.netlify.com/sites/apisix/deploys/60940e955b86fb0007d02926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* ready!
Built with commit 524d6e56fae80bbe06e11f555d30e386546045fb
https://deploy-preview-333--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
Deploy preview for *apisix* processing.
Building with commit b2dc50eb5aa84e40aefa1fcc5db04691d3a5b3f1
https://app.netlify.com/sites/apisix/deploys/609587a6e7a92a00080f2997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#discussion_r628671872
##########
File path: website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md
##########
@@ -16,7 +16,7 @@ authorImageURL: "https://avatars0.githubusercontent.com/u/10428333?s=60&v=4"
> - https://github.com/apache/apisix-helm-chart
> - https://github.com/apache/apisix-ingress-controller
-This post is based on [Install Ingress APISIX on Amazon EKS](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/aws.md).
+This post is based on [Install Ingress APISIX on Amazon EKS](http://apisix.incubator.apache.org/docs/ingress-controller/deployments/aws/).
Review comment:
already fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#discussion_r628069973
##########
File path: website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md
##########
@@ -16,7 +16,7 @@ authorImageURL: "https://avatars0.githubusercontent.com/u/10428333?s=60&v=4"
> - https://github.com/apache/apisix-helm-chart
> - https://github.com/apache/apisix-ingress-controller
-This post is based on [Install Ingress APISIX on Amazon EKS](https://github.com/apache/apisix-ingress-controller/blob/master/docs/deployments/aws.md).
Review comment:
might be better to use the website link
http://apisix.incubator.apache.org/docs/ingress-controller/deployments/aws/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #333:
URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org