[jira] [Commented] (GORA-255) Remove deprecated methods from DataStoreTestBase

["Nishadi Kirielle (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GORA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032450#comment-16032450 ] 

Nishadi Kirielle commented on GORA-255:
---------------------------------------

Hi, 
Thank you for the responses. 
If we are to remove those methods, we will need to create  MemStoreTestDriver to retain that functionality.
But will it be meaningful to create the test drive for MemStore just because we need to initialize the data stores of employee and web store DataStores. AFAIU, GoraTestDriver [1] is a helper class for managing third party tests, but MemStoreTest won't be having any third party tests.  
Your suggestions on this will be really helpful. 
Thank you!
[1]. https://github.com/apache/gora/blob/apache-gora-0.7/gora-core/src/test/java/org/apache/gora/GoraTestDriver.java#L38

> Remove deprecated methods from DataStoreTestBase 
> -------------------------------------------------
>
>                 Key: GORA-255
>                 URL: https://issues.apache.org/jira/browse/GORA-255
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: testing
>    Affects Versions: 0.4
>            Reporter: Apostolos Giannakidis
>            Assignee: Apostolos Giannakidis
>            Priority: Minor
>              Labels: test
>             Fix For: 0.8
>
>
> The abstract class DataStoreTestBase contains 2 deprecated methods:
> DataStore<String, Employee> createEmployeeDataStore()
> DataStore<String, WebPage> createWebPageDataStore()
> These methods were useful in the past but they seem not to be useful now.
> I believe that they should be removed from the abstract class DataStoreTestBase. Their concrete implementations from the subclasses that extend the DataStoreTestBase should also be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)