You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2008/02/28 11:33:17 UTC
[jira] Created: (SM-1255) Ability to not check duplicate files when
uploading
Ability to not check duplicate files when uploading
---------------------------------------------------
Key: SM-1255
URL: https://issues.apache.org/activemq/browse/SM-1255
Project: ServiceMix
Issue Type: Improvement
Components: servicemix-ftp
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
Fix For: 3.2.2, 3.3
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SM-1255) Ability to not check duplicate files
when uploading
Posted by Gert Vanthienen <ge...@skynet.be>.
Guillaume,
Thank you for the clarification!
I couldn't think of another use case myself for disabling the duplicate
check without overwriting the existing file, but here it is... ;)
Speaking of edge cases, did you know the commons-net FTP API can't deal
with a leap day (https://issues.apache.org/jira/browse/NET-188 and
https://issues.apache.org/jira/browse/NET-190)? I just found out about
this feature yesterday (obviously...)
Gert
Guillaume Nodet wrote:
> Well, IIRC the overwrite first delete the file. We had a use case
> where the FTP backend was some sort of mailbox which allow duplicate
> files without really overwriting it. It's an edge case, but the
> purpose it to not delete the file before copying another with the same
> name.
> Makes sense ?
>
> On Sat, Mar 1, 2008 at 2:56 PM, Gert Vanthienen (JIRA) <ji...@apache.org> wrote:
>
>> [ https://issues.apache.org/activemq/browse/SM-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41480#action_41480 ]
>>
>> Gert Vanthienen commented on SM-1255:
>> -------------------------------------
>>
>> Guillaume,
>>
>>
>> Wouldn't it be a better solution to reuse the already existing 'overwrite' property to shortcut the if clause to avoid the check instead of adding another property with (almost) the same meaning?
>>
>> Something like
>> {code}
>> if (overwrite || client.listFiles(name).length == 0) {
>> ...
>> }
>>
>>
>> Gert
>>
>> > Ability to not check duplicate files when uploading
>> > ---------------------------------------------------
>> >
>> > Key: SM-1255
>> > URL: https://issues.apache.org/activemq/browse/SM-1255
>> > Project: ServiceMix
>> > Issue Type: Improvement
>> > Components: servicemix-ftp
>> > Reporter: Guillaume Nodet
>> > Assignee: Guillaume Nodet
>> > Fix For: 3.2.2, 3.3
>> >
>> >
>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>>
>
>
>
>
Re: [jira] Commented: (SM-1255) Ability to not check duplicate files when uploading
Posted by Guillaume Nodet <gn...@gmail.com>.
Well, IIRC the overwrite first delete the file. We had a use case
where the FTP backend was some sort of mailbox which allow duplicate
files without really overwriting it. It's an edge case, but the
purpose it to not delete the file before copying another with the same
name.
Makes sense ?
On Sat, Mar 1, 2008 at 2:56 PM, Gert Vanthienen (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/activemq/browse/SM-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41480#action_41480 ]
>
> Gert Vanthienen commented on SM-1255:
> -------------------------------------
>
> Guillaume,
>
>
> Wouldn't it be a better solution to reuse the already existing 'overwrite' property to shortcut the if clause to avoid the check instead of adding another property with (almost) the same meaning?
>
> Something like
> {code}
> if (overwrite || client.listFiles(name).length == 0) {
> ...
> }
>
>
> Gert
>
> > Ability to not check duplicate files when uploading
> > ---------------------------------------------------
> >
> > Key: SM-1255
> > URL: https://issues.apache.org/activemq/browse/SM-1255
> > Project: ServiceMix
> > Issue Type: Improvement
> > Components: servicemix-ftp
> > Reporter: Guillaume Nodet
> > Assignee: Guillaume Nodet
> > Fix For: 3.2.2, 3.3
> >
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
[jira] Commented: (SM-1255) Ability to not check duplicate files
when uploading
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41480#action_41480 ]
Gert Vanthienen commented on SM-1255:
-------------------------------------
Guillaume,
Wouldn't it be a better solution to reuse the already existing 'overwrite' property to shortcut the if clause to avoid the check instead of adding another property with (almost) the same meaning?
Something like
{code}
if (overwrite || client.listFiles(name).length == 0) {
...
}
Gert
> Ability to not check duplicate files when uploading
> ---------------------------------------------------
>
> Key: SM-1255
> URL: https://issues.apache.org/activemq/browse/SM-1255
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-ftp
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: 3.2.2, 3.3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1255) Ability to not check duplicate files when
uploading
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated SM-1255:
--------------------------------
Fix Version/s: servicemix-ftp-2008.01
> Ability to not check duplicate files when uploading
> ---------------------------------------------------
>
> Key: SM-1255
> URL: https://issues.apache.org/activemq/browse/SM-1255
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-ftp
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: 3.2.2, 3.3, servicemix-ftp-2008.01
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1255) Ability to not check duplicate files
when uploading
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SM-1255.
---------------------------------
Resolution: Fixed
Sending deployables/bindingcomponents/servicemix-ftp/src/main/java/org/apache/servicemix/ftp/FtpSenderEndpoint.java
Transmitting file data .
Committed revision 631922.
Sending deployables/bindingcomponents/servicemix-ftp/src/main/java/org/apache/servicemix/ftp/FtpSenderEndpoint.java
Transmitting file data .
Committed revision 631923.
> Ability to not check duplicate files when uploading
> ---------------------------------------------------
>
> Key: SM-1255
> URL: https://issues.apache.org/activemq/browse/SM-1255
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-ftp
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: 3.2.2, 3.3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.