[jira] [Commented] (AIRFLOW-3566) MsSqlHook timeout is not configurable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748040#comment-16748040 ] 

ASF GitHub Bot commented on AIRFLOW-3566:
-----------------------------------------

eladkal commented on pull request #4566: [AIRFLOW-3566] - Adding timeout and login_timeout to MsSqlHook
URL: https://github.com/apache/airflow/pull/4566
 
 
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3566) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3566
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   Adding timeout and login_timeout properties.
   timeout  - property of the query (query timeout in seconds).
   login_timeout -  property of connection (timeout for connection) allowing it to be set from Connection and overwrite in the hook.
   
   Default values (preserve backwards comparability):
   timeout default value is 0 (no timeout)
   login_timeout default value is 60
   
   
   ### Code Quality
   
   - [V] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> MsSqlHook timeout is not configurable
> -------------------------------------
>
>                 Key: AIRFLOW-3566
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3566
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>            Reporter: Mark Zitnik
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> I have looking on MsSqlHook implementation it uses the default timeout of the driver  -> is no timeout.
> uses internally pymssql the default time is 0 -> is no timeout look at http://pymssql.org/en/stable/ref/pymssql.html
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)