You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by rs...@apache.org on 2025/07/05 15:48:01 UTC
(httpcomponents-client) branch master updated: Jep380SocketChannelAdapter: Connect in blocking mode
This is an automated email from the ASF dual-hosted git repository.
rschmitt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git
The following commit(s) were added to refs/heads/master by this push:
new c01d4125a Jep380SocketChannelAdapter: Connect in blocking mode
c01d4125a is described below
commit c01d4125aee25a5254fb0c05a99a6cc4fade25fd
Author: Ryan Schmitt <rs...@apache.org>
AuthorDate: Sat Jul 5 00:07:21 2025 -0700
Jep380SocketChannelAdapter: Connect in blocking mode
This fixes UDS integration test failures on Windows and Java 17+.
---
.../org/apache/hc/client5/http/socket/Jep380SocketChannelAdapter.java | 2 ++
.../apache/hc/client5/http/socket/Jep380SocketChannelImplAdapter.java | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelAdapter.java b/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelAdapter.java
index b124e6bb1..487f13490 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelAdapter.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelAdapter.java
@@ -51,11 +51,13 @@ private Jep380SocketChannelAdapter(final SocketChannel channel, final Jep380Sock
@Override
public void connect(final SocketAddress endpoint, final int timeout) throws IOException {
channel.connect(endpoint);
+ channel.configureBlocking(false);
}
@Override
public void connect(final SocketAddress endpoint) throws IOException {
channel.connect(endpoint);
+ channel.configureBlocking(false);
}
@Override
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelImplAdapter.java b/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelImplAdapter.java
index c35a491dd..1d4875f91 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelImplAdapter.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelImplAdapter.java
@@ -49,7 +49,6 @@ final class Jep380SocketChannelImplAdapter extends SocketImpl {
public Jep380SocketChannelImplAdapter(final SocketChannel channel) throws IOException {
this.channel = channel;
- channel.configureBlocking(false);
}
@Override