You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/10/20 09:04:45 UTC
[GitHub] [calcite] liyafan82 opened a new pull request #2227: [CALCITE-4342] More aggregate functions should be marked as splittable and ignore distinct optionality (Liya Fan)
liyafan82 opened a new pull request #2227:
URL: https://github.com/apache/calcite/pull/2227
Please see the discussions in https://issues.apache.org/jira/browse/CALCITE-4342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liyafan82 commented on a change in pull request #2227: [CALCITE-4342] More aggregate functions should be marked as splittable and ignore distinct optionality
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #2227:
URL: https://github.com/apache/calcite/pull/2227#discussion_r510005341
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlAggFunction.java
##########
@@ -204,4 +204,11 @@ public boolean allowsFilter() {
public boolean allowsNullTreatment() {
return false;
}
+
+ /**
+ * Get rollup aggregation function.
+ */
+ public SqlAggFunction getRollup() {
Review comment:
Fixed. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liyafan82 merged pull request #2227: [CALCITE-4342] More aggregate functions should be marked as splittable and ignore distinct optionality
Posted by GitBox <gi...@apache.org>.
liyafan82 merged pull request #2227:
URL: https://github.com/apache/calcite/pull/2227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liyafan82 commented on pull request #2227: [CALCITE-4342] More aggregate functions should be marked as splittable and ignore distinct optionality
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #2227:
URL: https://github.com/apache/calcite/pull/2227#issuecomment-797369572
Merging. Thanks a lot for your comments. @chunweilei
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liyafan82 commented on pull request #2227: [CALCITE-4342] More aggregate functions should be marked as splittable and ignore distinct optionality
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #2227:
URL: https://github.com/apache/calcite/pull/2227#issuecomment-791238755
If there are no objections, I want to merge this PR in a few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] chunweilei commented on a change in pull request #2227: [CALCITE-4342] More aggregate functions should be marked as splittable and ignore distinct optionality
Posted by GitBox <gi...@apache.org>.
chunweilei commented on a change in pull request #2227:
URL: https://github.com/apache/calcite/pull/2227#discussion_r509843240
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlAggFunction.java
##########
@@ -204,4 +204,11 @@ public boolean allowsFilter() {
public boolean allowsNullTreatment() {
return false;
}
+
+ /**
+ * Get rollup aggregation function.
+ */
+ public SqlAggFunction getRollup() {
Review comment:
Get -> Gets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org