[GitHub] [geode] jujoramos opened pull request #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["jujoramos (GitHub)" <gi...@apache.org>]

GEODE-5830: Fix `NONE` enum for SSL configuration

The `SecurableCommunicationChannel.NONE` enum instance now references
the correct constant string, `none`, instead of `NO_COMPONENT`.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["galen-pivotal (GitHub)" <gi...@apache.org>]

Suuuper minor grammatical suggestion: put a comma after "all", so that there are clearly three commma-separated options.

[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["galen-pivotal (GitHub)" <gi...@apache.org>]

This should be made a constant, `SecurableCommunicationChannels.NONE`, to be consistent with the other declarations.

[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on issue #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["jujoramos (GitHub)" <gi...@apache.org>]

Hello @galen-pivotal,

I've made the changes, thanks.
Regarding the code style guide, I was aware of it but I keep seeing one-line control blocks without brackets in new commits, so I assumed that the style guide changed and never went a checked the link again, sorry about that :-). It'd be worth modifying the `spotless` plugin to enforce this rule, BTW.
I'll wait for the CI to finish and I'll merge the changes afterwards, thanks again!.
Cheers.

[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on issue #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["jujoramos (GitHub)" <gi...@apache.org>]

Agreed @galen-pivotal, I'll remove the `none` constant altogether and update the docs + tests.
Cheers.

[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["galen-pivotal (GitHub)" <gi...@apache.org>]

<s>This should be made a constant, `SecurableCommunicationChannels.NONE`, to be consistent with the other declarations.</s>
I think I was wrong about this -- however, we have the other channels supported as a comma-separated list, and I don't think it makes sense to have `none` included as a member of that list.

[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["galen-pivotal (GitHub)" <gi...@apache.org>]

Good cleanup here.

However, per [the style guide](https://cwiki.apache.org/confluence/display/GEODE/Code+Style+Guide), "Always use braces, even around one-line `if`, `else` and other control statements."


[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos closed pull request #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["jujoramos (GitHub)" <gi...@apache.org>]

[ pull request closed by jujoramos ]

[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on issue #2581: GEODE-5830: Fix `NONE` enum for SSL configuration

["galen-pivotal (GitHub)" <gi...@apache.org>]

@jujoramos if you want, I'm happy to add the braces and merge. Just figured it might be helpful to get feedback on the style guide.

[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org