You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Bill Au (JIRA)" <ji...@apache.org> on 2007/09/01 03:19:19 UTC
[jira] Created: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
need to improve snapinstaller to ignore non-snapshots in data directory
-----------------------------------------------------------------------
Key: SOLR-346
URL: https://issues.apache.org/jira/browse/SOLR-346
Project: Solr
Issue Type: Improvement
Components: replication
Reporter: Bill Au
Assignee: Bill Au
Priority: Minor
http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> installed
A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-346) need to improve snapinstaller to
ignore non-snapshots in data directory
Posted by "Jason Wambach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677810#action_12677810 ]
Jason Wambach commented on SOLR-346:
------------------------------------
The patched line should be:
name=`perl -e 'chdir q|'${data_dir}'|; print ((sort grep {/^snapshot[.][1-9][0-9]{13}$/} <*>)[-1])'`
not
name=`perl -e 'chdir q|${data_dir}|; print ((sort grep {/^snapshot[.][1-9][0-9]{13}$/} <*>)[-1])'`
The latter will not properly evaluate the data_dir env variable.
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.3.1
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Bill Au (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Au updated SOLR-346:
-------------------------
Attachment: solr-346-2.patch
attaching new patch to fix snapinstaller
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.4
>
> Attachments: solr-346-2.patch, solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-346) need to improve snapinstaller to
ignore non-snapshots in data directory
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678074#action_12678074 ]
Steven Rowe commented on SOLR-346:
----------------------------------
Jason, I think you're right.
The following script:
{code}
#!/bin/bash
data_dir=something
name=`perl -e 'print q|${data_dir}|;'`
echo "As it is: $name"
name=`perl -e 'print q|'${data_dir}'|;'`
echo "As you would have it: $name"
{code}
Produces this output:
{noformat}
As it is: ${data_dir}
As you would have it: something
{noformat}
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.3.1
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Bill Au (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Au updated SOLR-346:
-------------------------
Affects Version/s: 1.2
1.3
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Bill Au (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Au updated SOLR-346:
-------------------------
Attachment: solr-346.patch
patch to use perl regular expression to improve accuracy in finding latest snapshot.
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.3.1
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Bill Au (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Au resolved SOLR-346.
--------------------------
Resolution: Fixed
Patch committed:
Sending CHANGES.txt
Sending src/scripts/snapinstaller
Transmitting file data ..
Committed revision 719232.
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.3.1
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic updated SOLR-346:
----------------------------------
Fix Version/s: 1.3.1
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.3.1
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Bill Au (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Au resolved SOLR-346.
--------------------------
Resolution: Fixed
I went ahead and committed the code change:
Sending snapinstaller
Transmitting file data .
Committed revision 750048.
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.4
>
> Attachments: solr-346-2.patch, solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-346) need to improve snapinstaller to
ignore non-snapshots in data directory
Posted by "Bill Au (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644007#action_12644007 ]
Bill Au commented on SOLR-346:
------------------------------
snappuller has the same problem. See SOLR-830 (https://issues.apache.org/jira/browse/SOLR-830) for details. The proposed solution there should work here also.
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-346) need to improve snapinstaller to
ignore non-snapshots in data directory
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678137#action_12678137 ]
Steven Rowe commented on SOLR-346:
----------------------------------
BTW, I tested the similar change made to snappuller under SOLR-830, and it does *not* have the same interpolation issue:
{code}
snap_name=`ssh -o StrictHostKeyChecking=no ${master_host} \
"perl -e 'chdir ${master_data_dir}|; print ((sort grep {/^snapshot[.][1-9][0-9]{13}$/} <*>)[-1])'"`
{code}
Since the perl script is enclosed in double quotes, ${master_data_dir} is properly interpolated before perl sees it.
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.4
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-346) need to improve
snapinstaller to ignore non-snapshots in data directory
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678137#action_12678137 ]
steve_rowe edited comment on SOLR-346 at 3/2/09 2:39 PM:
----------------------------------------------------------
BTW, I tested the similar change made to snappuller under SOLR-830, and it does *not* have the same interpolation issue:
{code}
snap_name=`ssh -o StrictHostKeyChecking=no ${master_host} \
"perl -e 'chdir q|${master_data_dir}|; print ((sort grep {/^snapshot[.][1-9][0-9]{13}$/} <*>)[-1])'"`
{code}
Since the shell script containing the perl script is enclosed in double quotes, ${master_data_dir} is properly interpolated before perl sees it.
was (Author: steve_rowe):
BTW, I tested the similar change made to snappuller under SOLR-830, and it does *not* have the same interpolation issue:
{code}
snap_name=`ssh -o StrictHostKeyChecking=no ${master_host} \
"perl -e 'chdir ${master_data_dir}|; print ((sort grep {/^snapshot[.][1-9][0-9]{13}$/} <*>)[-1])'"`
{code}
Since the perl script is enclosed in double quotes, ${master_data_dir} is properly interpolated before perl sees it.
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.4
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic updated SOLR-346:
----------------------------------
Fix Version/s: (was: 1.3.1)
1.4
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.4
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SOLR-346) need to improve snapinstaller to ignore
non-snapshots in data directory
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic reopened SOLR-346:
-----------------------------------
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
> Key: SOLR-346
> URL: https://issues.apache.org/jira/browse/SOLR-346
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.2, 1.3
> Reporter: Bill Au
> Assignee: Bill Au
> Priority: Minor
> Fix For: 1.4
>
> Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail. Snapinstaller should be improved to ignore any much non-snapshot as possible. It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.