You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/24 16:44:30 UTC

[GitHub] [iceberg] karuppayya commented on a diff in pull request #3435: Add schema validation during parquet file Import

karuppayya commented on code in PR #3435:
URL: https://github.com/apache/iceberg/pull/3435#discussion_r906232772


##########
api/src/main/java/org/apache/iceberg/types/ImportCompatibilityChecker.java:
##########
@@ -0,0 +1,149 @@
+/*

Review Comment:
   I am trying to see if we can reuse org.apache.iceberg.types.CheckCompatibility#readCompatibilityErrors and avoid this class completely. Will update the PR with my findings



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org