You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/12 14:39:19 UTC
[GitHub] [superset] geido opened a new pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
geido opened a new pull request #16232:
URL: https://github.com/apache/superset/pull/16232
### SUMMARY
This PR fixes an issue with the scrollbar in the Change Dataset modal that was scrolling too far at the bottom.
Different from the ask in the related issue #15935, this PR does not stop the scrollbar from going over the sticky header. In order to stop the scrollbar from appearing over the sticky header, a complete refactor of the TableCollection component would be required. In fact, that behaviour is standard in the HTML tables when a sticky header is used. A full deviation from the standard HTML table would be required. For instance, the "Table" chart has a full custom implementation of the table in order to stop the scrollbar from going over the sticky header.
### BEFORE
<img width="878" alt="Screen Shot 2021-07-28 at 10 41 38 AM" src="https://user-images.githubusercontent.com/67837651/127398200-713c6564-496b-4bbf-b82b-bcf05401ba26.png">
### AFTER
https://user-images.githubusercontent.com/60598000/129215292-6d07c6b7-f6d9-4c74-8133-90c45ac59a7f.mp4
### TESTING INSTRUCTIONS
1. Open Explore
2. Click on "Change dataset"
3. Observe the table and scroll
4. Make sure the scrollbar does not appear down to the pagination
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #15935
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16232:
URL: https://github.com/apache/superset/pull/16232#issuecomment-897725245
@geido Ephemeral environment spinning up at http://35.167.213.219:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #16232:
URL: https://github.com/apache/superset/pull/16232#issuecomment-897906788
I have noticed a cosmetic issue that is also affecting main. With no pagination, there is a big blank space at the bottom of the Modal. I will file a separate issue for this problem and solve it in a separate PR as it is not related to the scrollbar.
https://user-images.githubusercontent.com/60598000/129256458-4a582b35-11d2-42a0-afb0-c3911b5957d8.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16232:
URL: https://github.com/apache/superset/pull/16232#issuecomment-897723458
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16232:
URL: https://github.com/apache/superset/pull/16232#issuecomment-897906788
I have noticed a cosmetic issue that is also affecting main. With no pagination, there is a big blank space at the bottom. I will file a separate issue for this problem and solve it in a separate PR as it is not related to the scrollbar.
https://user-images.githubusercontent.com/60598000/129256458-4a582b35-11d2-42a0-afb0-c3911b5957d8.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
Posted by GitBox <gi...@apache.org>.
geido merged pull request #16232:
URL: https://github.com/apache/superset/pull/16232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16232:
URL: https://github.com/apache/superset/pull/16232#issuecomment-899569082
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16232: fix: Stop the scrollbar in the Change Dataset modal from scrolling down to the pagination component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16232:
URL: https://github.com/apache/superset/pull/16232#issuecomment-897714114
# [Codecov](https://codecov.io/gh/apache/superset/pull/16232?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16232](https://codecov.io/gh/apache/superset/pull/16232?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fba9b17) into [master](https://codecov.io/gh/apache/superset/commit/7de54d016e01e80fdd7c967d1e57e69209a30ea7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7de54d0) will **increase** coverage by `0.01%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/superset/pull/16232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16232 +/- ##
==========================================
+ Coverage 76.70% 76.71% +0.01%
==========================================
Files 996 996
Lines 53045 53054 +9
Branches 6739 6741 +2
==========================================
+ Hits 40687 40701 +14
+ Misses 12129 12124 -5
Partials 229 229
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.99% <88.88%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/16232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `94.44% <88.88%> (-1.34%)` | :arrow_down: |
| [...onalFormattingControl/FormattingPopoverContent.tsx](https://codecov.io/gh/apache/superset/pull/16232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=) | `53.06% <0.00%> (+23.79%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16232?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16232?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7de54d0...fba9b17](https://codecov.io/gh/apache/superset/pull/16232?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org