You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/02 17:57:54 UTC

[GitHub] [geode-native] davebarnes97 commented on a change in pull request #755: Updates README.md, CONTRIBUTING.md and BUILDING.md

davebarnes97 commented on a change in pull request #755:
URL: https://github.com/apache/geode-native/pull/755#discussion_r585786124



##########
File path: CONTRIBUTING.md
##########
@@ -156,7 +217,8 @@ When writing new or refactoring old code please make the following changes.
     }
     ```
 
-  * Fix [`std::string::c_str()`](http://en.cppreference.com/w/cpp/string/basic_string/c_str) calls where passed to [`std::string`](http://en.cppreference.com/w/cpp/string/basic_string) parameters.
+  * Fix [`std::string::c_str()`](http://en.cppreference.com/w/cpp/string/basic_string/c_str) calls where passed to 

Review comment:
       When I view this section using macdown, this bullet and those that follow are indented under the preceding text. I'm not sure if this is what you intended. LMK if you'd like me to reformat this section.
   
   ![Screen Shot 2021-03-02 at 9 53 18 AM](https://user-images.githubusercontent.com/13138489/109692687-abc57c80-7b3d-11eb-8ef4-58978b7fa009.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org