You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/29 09:04:30 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #373: interpreters/duktape: Link headers to include/interpreters
no1wudi opened a new pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373
## Summary
This is useful for using duktape as a library.
## Impact
None
## Testing
Tested on sim & stm32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#discussion_r479655155
##########
File path: interpreters/duktape/Makefile
##########
@@ -48,23 +48,30 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert
CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
+APPINC = $(CURDIR)/$(DUKTAPE_UNPACK)
+
$(DUKTAPE_TARBALL):
- @echo "Downloading $(DUKTAPE_TARBALL)"
- @wget $(DUKTAPE_URL)
+ $(Q) echo "Downloading $(DUKTAPE_TARBALL)"
+ $(Q) wget $(DUKTAPE_URL)
$(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
- @echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
- @tar xvfJ $(DUKTAPE_TARBALL)
- @echo "Patching $(DUKTAPE_UNPACK)"
- @patch -p0 < duk_cmdline.patch
- @touch $(DUKTAPE_UNPACK)/.patch
+ $(Q) echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
+ $(Q) tar xvfJ $(DUKTAPE_TARBALL)
+ $(Q) mv duktape-$(DUKTAPE_VERSION) $(DUKTAPE_UNPACK)
+ $(Q) ln -sf $(APPINC)/src-noline/duktape.h $(APPINC)/duktape.h
Review comment:
change all $(APPINC) to $(DUKTAPE_UNPACK)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi edited a comment on pull request #373: interpreters/duktape: Link headers to include/interpreters
Posted by GitBox <gi...@apache.org>.
no1wudi edited a comment on pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#issuecomment-683264828
> let's use the method simliar with lvgl instead?
But the app want to use Duktape must add include path to CFLAGS manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on pull request #373: interpreters/duktape: Link headers to include/interpreters
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#issuecomment-683264828
> let's use the method simliar with lvgl instead?
But the app want to use Duktape must add include path to CFLAGS manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#discussion_r479650973
##########
File path: interpreters/duktape/Makefile
##########
@@ -48,23 +48,31 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert
CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
+APPINC = $(CURDIR)/$(DUKTAPE_UNPACK)
+
$(DUKTAPE_TARBALL):
- @echo "Downloading $(DUKTAPE_TARBALL)"
- @wget $(DUKTAPE_URL)
+ $(Q) echo "Downloading $(DUKTAPE_TARBALL)"
+ $(Q) wget $(DUKTAPE_URL)
$(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
- @echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
- @tar xvfJ $(DUKTAPE_TARBALL)
- @echo "Patching $(DUKTAPE_UNPACK)"
- @patch -p0 < duk_cmdline.patch
- @touch $(DUKTAPE_UNPACK)/.patch
+ $(Q) echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
+ $(Q) tar xvfJ $(DUKTAPE_TARBALL)
+ $(Q) ln -sf $(DUKTAPE_UNPACK) duktape
Review comment:
let's define DUKTAPE_UNPACK=duktape and mv duktape-2.5.0 to duktape directly instead link
##########
File path: interpreters/duktape/Makefile
##########
@@ -48,23 +48,31 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert
CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
+APPINC = $(CURDIR)/$(DUKTAPE_UNPACK)
+
$(DUKTAPE_TARBALL):
- @echo "Downloading $(DUKTAPE_TARBALL)"
- @wget $(DUKTAPE_URL)
+ $(Q) echo "Downloading $(DUKTAPE_TARBALL)"
+ $(Q) wget $(DUKTAPE_URL)
$(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
- @echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
- @tar xvfJ $(DUKTAPE_TARBALL)
- @echo "Patching $(DUKTAPE_UNPACK)"
- @patch -p0 < duk_cmdline.patch
- @touch $(DUKTAPE_UNPACK)/.patch
+ $(Q) echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
+ $(Q) tar xvfJ $(DUKTAPE_TARBALL)
+ $(Q) ln -sf $(DUKTAPE_UNPACK) duktape
+ $(Q) ln -sf $(APPINC)/src-noline/duktape.h $(APPINC)/duktape.h
+ $(Q) ln -sf $(APPINC)/src-noline/duk_config.h $(APPINC)/duk_config.h
Review comment:
don't need link header file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#discussion_r479657826
##########
File path: interpreters/duktape/Makefile
##########
@@ -48,23 +48,30 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert
CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
+APPINC = $(CURDIR)/$(DUKTAPE_UNPACK)
+
$(DUKTAPE_TARBALL):
- @echo "Downloading $(DUKTAPE_TARBALL)"
- @wget $(DUKTAPE_URL)
+ $(Q) echo "Downloading $(DUKTAPE_TARBALL)"
+ $(Q) wget $(DUKTAPE_URL)
$(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
- @echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
- @tar xvfJ $(DUKTAPE_TARBALL)
- @echo "Patching $(DUKTAPE_UNPACK)"
- @patch -p0 < duk_cmdline.patch
- @touch $(DUKTAPE_UNPACK)/.patch
+ $(Q) echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
+ $(Q) tar xvfJ $(DUKTAPE_TARBALL)
+ $(Q) mv duktape-$(DUKTAPE_VERSION) $(DUKTAPE_UNPACK)
+ $(Q) ln -sf $(APPINC)/src-noline/duktape.h $(APPINC)/duktape.h
Review comment:
$(DUKTAPE_UNPACK) is a relative path, may cause some problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#discussion_r479662169
##########
File path: interpreters/duktape/Makefile
##########
@@ -48,23 +48,28 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert
CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
+DUKINC = $(CURDIR)/$(DUKTAPE_UNPACK)
Review comment:
remove, no user.
##########
File path: interpreters/duktape/Makefile
##########
@@ -48,23 +48,28 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert
CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
+DUKINC = $(CURDIR)/$(DUKTAPE_UNPACK)
+
$(DUKTAPE_TARBALL):
- @echo "Downloading $(DUKTAPE_TARBALL)"
- @wget $(DUKTAPE_URL)
+ $(Q) echo "Downloading $(DUKTAPE_TARBALL)"
+ $(Q) wget $(DUKTAPE_URL)
$(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
- @echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
- @tar xvfJ $(DUKTAPE_TARBALL)
- @echo "Patching $(DUKTAPE_UNPACK)"
- @patch -p0 < duk_cmdline.patch
- @touch $(DUKTAPE_UNPACK)/.patch
+ $(Q) echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
+ $(Q) tar xvfJ $(DUKTAPE_TARBALL)
+ $(Q) mv duktape-$(DUKTAPE_VERSION) $(DUKTAPE_UNPACK)
+ $(Q) echo "Patching $(DUKTAPE_UNPACK)"
+ $(Q) patch -p0 < duk_cmdline.patch
$(DUKTAPE_UNPACK)/.patch: $(DUKTAPE_UNPACK)
+ $(Q) touch $(DUKTAPE_UNPACK)/.patch
context:: $(DUKTAPE_UNPACK)/.patch
distclean::
$(call DELDIR, $(DUKTAPE_UNPACK))
$(call DELFILE, $(DUKTAPE_TARBALL))
+ $(call DELFILE, duktape.h)
+ $(call DELFILE, duk_config.h)
Review comment:
remove, don't need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi removed a comment on pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
no1wudi removed a comment on pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#issuecomment-683264828
> let's use the method simliar with lvgl instead?
But the app want to use Duktape must add include path to CFLAGS manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #373: interpreters/duktape: Link headers to include/interpreters
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#issuecomment-683263093
let's use the method simliar with lvgl instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#issuecomment-683308949
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#discussion_r479662211
##########
File path: interpreters/duktape/.gitignore
##########
@@ -1 +1 @@
-duktape-*
+duktape*
Review comment:
add newline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #373: interpreters/duktape:Add duktape to global search path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org