[calcite] branch master updated: [CALCITE-2853] Avoid multithreaded execution of CalciteRemoteDriverTest

[vl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vladimirsitnikov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git


The following commit(s) were added to refs/heads/master by this push:
     new 3cefa45  [CALCITE-2853] Avoid multithreaded execution of CalciteRemoteDriverTest
3cefa45 is described below

commit 3cefa45ac13b9768e1a7b7e90ede77c6b6eec27b
Author: Vladimir Sitnikov <si...@gmail.com>
AuthorDate: Sat Feb 16 11:27:58 2019 +0300

    [CALCITE-2853] Avoid multithreaded execution of CalciteRemoteDriverTest
    
    Technically speaking, the test should pass even in concurrent mode,
    however Calcite remote driver does not support concurrency yet, so
    @NotThreadSafe is added to make CI pass.
---
 core/pom.xml                                                         | 5 +++++
 .../test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java   | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/core/pom.xml b/core/pom.xml
index 7758233..e810ce4 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -112,6 +112,11 @@ limitations under the License.
       <scope>test</scope>
     </dependency>
     <dependency>
+      <groupId>com.github.stephenc.jcip</groupId>
+      <artifactId>jcip-annotations</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
       <groupId>org.jetbrains.kotlin</groupId>
       <artifactId>kotlin-stdlib</artifactId>
       <scope>test</scope>
diff --git a/core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java b/core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java
index 862b26e..1f6957e 100644
--- a/core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java
+++ b/core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java
@@ -33,6 +33,8 @@ import org.apache.calcite.util.Util;
 
 import com.google.common.collect.ImmutableList;
 
+import net.jcip.annotations.NotThreadSafe;
+
 import org.hamcrest.CoreMatchers;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
@@ -81,7 +83,10 @@ import static org.junit.Assert.assertThat;
 
 /**
  * Test for Calcite's remote JDBC driver.
+ * Technically speaking, the test is thread safe, however Caclite/Avatica have thread-safety issues
+ * see https://issues.apache.org/jira/browse/CALCITE-2853.
  */
+@NotThreadSafe
 public class CalciteRemoteDriverTest {
   public static final String LJS = Factory2.class.getName();