[GitHub] [madlib] kaknikhil commented on issue #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA

[GitBox <gi...@apache.org>]

kaknikhil commented on issue #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA
URL: https://github.com/apache/madlib/pull/432#issuecomment-549962637
 
 
   @hpandeycodeit 
   We should test cases for the following scenarios (not sure if we already have tests for some of these) :
   1. If evaluate_every <=0, assert that there are no perplexity values.
   1. If tolerance == 0, assert that we don't stop early.
   1. All permutations of the interface with evaluate_every and tolerance being passed as NULL and/or not passed at all to make sure we default the values as expected. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services