You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jim Jagielski <ji...@jaguNET.com> on 2008/09/20 15:24:12 UTC
Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/
On Sat, Sep 20, 2008 at 11:58:09AM -0000, pquerna@apache.org wrote:
>
> Does anyone besides Rüdiger read commit emails :-) ?
>
No :)
> + else {
> + /* XXXXX: lol, pool allocation without a context from any thread.Yeah. Right. MPMs Suck. */
> + te = malloc(sizeof(timer_event_t));
> + APR_RING_ELEM_INIT(te, link);
> + }
> +
> -#define ap_queue_empty(queue) ((queue)->nelts == 0)
> +#define ap_queue_empty(queue) ((queue)->nelts == 0 && APR_RING_EMPTY(&queue->timers ,timer_event_t, link))
Not || ?
Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Sep 20, 2008, at 4:31 PM, Paul Querna wrote:
> Jim Jagielski wrote:
>> On Sat, Sep 20, 2008 at 11:58:09AM -0000, pquerna@apache.org wrote:
>>> -#define ap_queue_empty(queue) ((queue)->nelts == 0)
>>> +#define ap_queue_empty(queue) ((queue)->nelts == 0 &&
>>> APR_RING_EMPTY(&queue->timers ,timer_event_t, link))
>> Not || ?
>
> Don't think so?
>
> You want to return true if there are both zero entries in the array,
> and zero in the ring.
>
> And false if either has something in it.
>
Ahhh yes, we need to check both structs in the queue now.
Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/
modules/test/ server/ server/mpm/experimental/event/
Posted by Paul Querna <ch...@force-elite.com>.
Jim Jagielski wrote:
> On Sat, Sep 20, 2008 at 11:58:09AM -0000, pquerna@apache.org wrote:
>> -#define ap_queue_empty(queue) ((queue)->nelts == 0)
>> +#define ap_queue_empty(queue) ((queue)->nelts == 0 && APR_RING_EMPTY(&queue->timers ,timer_event_t, link))
>
> Not || ?
Don't think so?
You want to return true if there are both zero entries in the array, and
zero in the ring.
And false if either has something in it.