You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/04/19 10:40:09 UTC

Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1525
    https://issues.apache.org/jira/browse/RANGER-1525


Repository: ranger


Description
-------

Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to install Ranger through the platform or systems. We should support the need in the case of compatibility with existing logic.

Solution:
1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs.
2. The program read configuration information from the RANGER_ADMIN_CONF path.
3. Users can re-plan programs and configurations when installing the Ranger Admin. Then they set RANGER_ADMIN_CONF value as configuration path.


Diffs
-----

  security-admin/scripts/db_setup.py 6e79151 
  security-admin/scripts/dba_script.py 83d6fe7 
  security-admin/scripts/setup.sh e77b2a9 


Diff: https://reviews.apache.org/r/58529/diff/1/


Testing
-------


Thanks,

pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by pengjianhua <pe...@zte.com.cn>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/#review172879
-----------------------------------------------------------


Ship it!




Ship It!

- pengjianhua


On \u56db\u6708 24, 2017, 12:47 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58529/
> -----------------------------------------------------------
> 
> (Updated \u56db\u6708 24, 2017, 12:47 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1525
>     https://issues.apache.org/jira/browse/RANGER-1525
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to install Ranger through the platform or systems. We should support the need in the case of compatibility with existing logic.
> 
> Solution:
> 1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs.
> 2. The program read configuration information from the RANGER_ADMIN_CONF path.
> 3. Users can re-plan programs and configurations when installing the Ranger Admin. Then they set RANGER_ADMIN_CONF value as configuration path.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py 6e79151 
>   security-admin/scripts/dba_script.py 83d6fe7 
>   security-admin/scripts/setup.sh e77b2a9 
> 
> 
> Diff: https://reviews.apache.org/r/58529/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by Colm O hEigeartaigh <co...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/#review172771
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On April 24, 2017, 12:47 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58529/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 12:47 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1525
>     https://issues.apache.org/jira/browse/RANGER-1525
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to install Ranger through the platform or systems. We should support the need in the case of compatibility with existing logic.
> 
> Solution:
> 1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs.
> 2. The program read configuration information from the RANGER_ADMIN_CONF path.
> 3. Users can re-plan programs and configurations when installing the Ranger Admin. Then they set RANGER_ADMIN_CONF value as configuration path.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py 6e79151 
>   security-admin/scripts/dba_script.py 83d6fe7 
>   security-admin/scripts/setup.sh e77b2a9 
> 
> 
> Diff: https://reviews.apache.org/r/58529/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by pengjianhua <pe...@zte.com.cn>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/
-----------------------------------------------------------

(Updated April 24, 2017, 12:47 a.m.)

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.

Bugs: RANGER-1525
https://issues.apache.org/jira/browse/RANGER-1525

Repository: ranger

Description
-------

Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to install Ranger through the platform or systems. We should support the need in the case of compatibility with existing logic.

Solution:
1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs.
2. The program read configuration information from the RANGER_ADMIN_CONF path.
3. Users can re-plan programs and configurations when installing the Ranger Admin. Then they set RANGER_ADMIN_CONF value as configuration path.

Diffs (updated)
-----

security-admin/scripts/db_setup.py 6e79151
security-admin/scripts/dba_script.py 83d6fe7
security-admin/scripts/setup.sh e77b2a9

Diff: https://reviews.apache.org/r/58529/diff/4/

Changes: https://reviews.apache.org/r/58529/diff/3-4/

Testing
-------

Thanks,

pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by pengjianhua <pe...@zte.com.cn>.

(Updated April 22, 2017, 4:43 a.m.)

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.

Bugs: RANGER-1525
https://issues.apache.org/jira/browse/RANGER-1525

Repository: ranger

Description
-------

Diffs (updated)
-----

security-admin/scripts/db_setup.py 6e79151
security-admin/scripts/dba_script.py 83d6fe7
security-admin/scripts/setup.sh e77b2a9

Diff: https://reviews.apache.org/r/58529/diff/3/

Changes: https://reviews.apache.org/r/58529/diff/2-3/

Testing
-------

Thanks,

pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by pengjianhua <pe...@zte.com.cn>.

(Updated April 22, 2017, 3:42 a.m.)

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.

Bugs: RANGER-1525
https://issues.apache.org/jira/browse/RANGER-1525

Repository: ranger

Description
-------

Diffs (updated)
-----

security-admin/scripts/db_setup.py 6e79151
security-admin/scripts/dba_script.py 83d6fe7
security-admin/scripts/setup.sh e77b2a9

Diff: https://reviews.apache.org/r/58529/diff/2/

Changes: https://reviews.apache.org/r/58529/diff/1-2/

Testing
-------

Thanks,

pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by pengjianhua <pe...@zte.com.cn>.


> On April 21, 2017, 8:35 a.m., Colm O hEigeartaigh wrote:
> > In db_setup.py, it appears that RANGER_ADMIN_CONF is only used for the "if is_unix" block. It should work for windows as well. Same goes for dba_script.py. There is also some trailing whitespace after the "RANGER_ADMIN_CONF" definition in both python files that could be fixed.

Ok. I fixed it according to your review and rebuit the patch. Thanks.


- pengjianhua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/#review172613
-----------------------------------------------------------


On April 22, 2017, 3:42 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58529/
> -----------------------------------------------------------
> 
> (Updated April 22, 2017, 3:42 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1525
>     https://issues.apache.org/jira/browse/RANGER-1525
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to install Ranger through the platform or systems. We should support the need in the case of compatibility with existing logic.
> 
> Solution:
> 1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs.
> 2. The program read configuration information from the RANGER_ADMIN_CONF path.
> 3. Users can re-plan programs and configurations when installing the Ranger Admin. Then they set RANGER_ADMIN_CONF value as configuration path.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py 6e79151 
>   security-admin/scripts/dba_script.py 83d6fe7 
>   security-admin/scripts/setup.sh e77b2a9 
> 
> 
> Diff: https://reviews.apache.org/r/58529/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by Colm O hEigeartaigh <co...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/#review172613
-----------------------------------------------------------



In db_setup.py, it appears that RANGER_ADMIN_CONF is only used for the "if is_unix" block. It should work for windows as well. Same goes for dba_script.py. There is also some trailing whitespace after the "RANGER_ADMIN_CONF" definition in both python files that could be fixed.

- Colm O hEigeartaigh


On April 19, 2017, 10:40 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58529/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 10:40 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1525
>     https://issues.apache.org/jira/browse/RANGER-1525
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to install Ranger through the platform or systems. We should support the need in the case of compatibility with existing logic.
> 
> Solution:
> 1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs.
> 2. The program read configuration information from the RANGER_ADMIN_CONF path.
> 3. Users can re-plan programs and configurations when installing the Ranger Admin. Then they set RANGER_ADMIN_CONF value as configuration path.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py 6e79151 
>   security-admin/scripts/dba_script.py 83d6fe7 
>   security-admin/scripts/setup.sh e77b2a9 
> 
> 
> Diff: https://reviews.apache.org/r/58529/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to uniform install Ranger.

Posted by Qiang Zhang <zh...@zte.com.cn>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/#review172571
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On \u56db\u6708 19, 2017, 10:40 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58529/
> -----------------------------------------------------------
> 
> (Updated \u56db\u6708 19, 2017, 10:40 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1525
>     https://issues.apache.org/jira/browse/RANGER-1525
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or business systems to install Ranger through the platform or systems. We should support the need in the case of compatibility with existing logic.
> 
> Solution:
> 1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs.
> 2. The program read configuration information from the RANGER_ADMIN_CONF path.
> 3. Users can re-plan programs and configurations when installing the Ranger Admin. Then they set RANGER_ADMIN_CONF value as configuration path.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py 6e79151 
>   security-admin/scripts/dba_script.py 83d6fe7 
>   security-admin/scripts/setup.sh e77b2a9 
> 
> 
> Diff: https://reviews.apache.org/r/58529/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>