You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by Jave-Chen <ke...@foxmail.com> on 2020/04/25 15:33:42 UTC
回复: [PROPOSAL] Add static check to our codebase
For code style, you can follow this thread
https://lists.apache.org/thread.html/r348ce4f6e11924defc11668b8799cd26a893f290890652888b4d33dc%40%3Cdev.dolphinscheduler.apache.org%3E
We planned to use Ali style , but didn't find a proper checkstyle file.
------------------ 原始邮件 ------------------
发件人: "Jiajie Zhong"<zhongjiajie955@hotmail.com>;
发送时间: 2020年4月25日(星期六) 晚上11:28
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: Re: [PROPOSAL] Add static check to our codebase
Oh I found out that, But why https://github.com/apache/incubator-dolphinscheduler/pull/2363 <https://github.com/apache/incubator-dolphinscheduler/pull/2363>
still have so many code style change? Did sonar check code style too?
Or maybe we still WIP about code style cover in the project?
Best Wish
— Jiajie
Re: [PROPOSAL] Add static check to our codebase
Posted by lidong dai <da...@gmail.com>.
looking forward to your contribution.
Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------
Jave-Chen <ke...@foxmail.com> 于2020年4月25日周六 下午11:39写道:
> Code style is always a problem that needs to be solved,
> looking forward to your contribution.
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "Jiajie Zhong"<zhongjiajie955@hotmail.com>;
> 发送时间: 2020年4月25日(星期六) 晚上11:34
> 收件人: "dev"<dev@dolphinscheduler.apache.org>;
>
> 主题: Re: [PROPOSAL] Add static check to our codebase
>
>
>
> Thanks, Got it
>
> Best Wish
> — Jiajie
re: [PROPOSAL] Add static check to our codebase
Posted by Jave-Chen <ke...@foxmail.com>.
Code style is always a problem that needs to be solved,
looking forward to your contribution.
------------------ 原始邮件 ------------------
发件人: "Jiajie Zhong"<zhongjiajie955@hotmail.com>;
发送时间: 2020年4月25日(星期六) 晚上11:34
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: Re: [PROPOSAL] Add static check to our codebase
Thanks, Got it
Best Wish
— Jiajie
Re: [PROPOSAL] Add static check to our codebase
Posted by Jiajie Zhong <zh...@hotmail.com>.
Thanks, Got it
Best Wish
— Jiajie