You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2022/01/05 06:01:00 UTC
[jira] [Resolved] (SOLR-15427) [child limit=...] should be unlimited by default
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley resolved SOLR-15427.
---------------------------------
Resolution: Fixed
On reconsideration, I think I prefer it as it is at the moment (unlimited). A high child doc count user might not want to even use [child] or if they do might be using {{childFilter}} local-param to select only those matching a pattern. These users can add a limit if they wish. Who knows what the right limit value should be for them. Whatever value we might choose for a default (5, 10, 100, ?) – such a user really ought to select the right number _for them_ (explicitly) rather than relying on arbitrary defaults. While this is true for a top level queries as well (i.e. for rows), there is a much higher risk there, not to mention we helpfully return the matching doc count (helping the user know many more may have matched) but there is no equivalent for child docs.
> [child limit=...] should be unlimited by default
> -------------------------------------------------
>
> Key: SOLR-15427
> URL: https://issues.apache.org/jira/browse/SOLR-15427
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Labels: NestedDocuments
> Fix For: main (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{[child]}} doc transformer's {{limit}} param defaults to 10, probably for consistency with top level {{rows}} param for search. But the number of child docs that a parent doc may have won't be massive by comparison. The default of 10 is a gotcha IMO – a user may wonder why they don't see everything they gave to Solr. We should just remove the limit by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org