You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2014/10/21 02:41:39 UTC
git commit: CB-5892 - Remove deprecated window.Settings
Repository: cordova-plugin-device
Updated Branches:
refs/heads/master 56677ed8a -> 974ef81cb
CB-5892 - Remove deprecated window.Settings
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-device/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-device/commit/974ef81c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-device/tree/974ef81c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-device/diff/974ef81c
Branch: refs/heads/master
Commit: 974ef81cbb4135c4a66d4d3b078aee864cefede6
Parents: 56677ed
Author: Shazron Abdullah <sh...@apache.org>
Authored: Mon Oct 20 17:41:37 2014 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Mon Oct 20 17:41:37 2014 -0700
----------------------------------------------------------------------
src/ios/CDVDevice.m | 14 --------------
1 file changed, 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-device/blob/974ef81c/src/ios/CDVDevice.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVDevice.m b/src/ios/CDVDevice.m
index 7e18d92..36e48e3 100644
--- a/src/ios/CDVDevice.m
+++ b/src/ios/CDVDevice.m
@@ -50,20 +50,6 @@
NSDictionary* deviceProperties = [self deviceProperties];
CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsDictionary:deviceProperties];
- /* Settings.plist
- * Read the optional Settings.plist file and push these user-defined settings down into the web application.
- * This can be useful for supplying build-time configuration variables down to the app to change its behavior,
- * such as specifying Full / Lite version, or localization (English vs German, for instance).
- */
- // TODO: turn this into an iOS only plugin
- NSDictionary* temp = [CDVViewController getBundlePlist:@"Settings"];
-
- if ([temp respondsToSelector:@selector(JSONString)]) {
- NSLog(@"Deprecation warning: window.Setting will be removed Aug 2013. Refer to https://issues.apache.org/jira/browse/CB-2433");
- NSString* js = [NSString stringWithFormat:@"window.Settings = %@;", [temp JSONString]];
- [self.commandDelegate evalJs:js];
- }
-
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org