[GitHub] [geode] demery-pivotal opened pull request #2938: GEODE-3613: Allocate unique ports to containers

["demery-pivotal (GitHub)" <gi...@apache.org>]

ServerContainer sometimes assigned the same port to multiple containers.

ServerContainer used AvailablePortHelper to allocate available ports.
Due to an inherent design flaw, AvailablePortHelper sometimes delivers
the same port number on multiple calls, which results in the same port
being used for multiple purposes.

ServerContainer now allocates ports using a single UniquePortSupplier
created by the test.

Additionally:

- Convert Cargo-based tests from DUnit base class to rule-based
- Start a new locator for each test
- Add cargo version to dependency-versions.properties
- Give each test class its own temp directory
- Fix bad check for container state validity
- Fix modify_war script to detect missing jar command and abort
- General test cleanup and de-duplication
- Announce start and end of each test to stdout

Co-Authored-By: Galen O'Sullivan <go...@pivotal.io>
Co-Authored-By: Dale Emery <de...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2938 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2938: GEODE-3613: Allocate unique ports to containers

["kirklund (GitHub)" <gi...@apache.org>]

The log4j syntax uses parameterization:
```
logger.info("Starting container {} RMI Port: {}", description, jvmJmxPort);
```

[ Full content available at: https://github.com/apache/geode/pull/2938 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #2938: GEODE-3613: Allocate unique ports to containers

["kirklund (GitHub)" <gi...@apache.org>]

[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/2938 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org