[GitHub] [pinot] siddharthteotia commented on a change in pull request #8112: Remove the usage of legacy ReplicaGroupStrategyConfig in segment assignment

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #8112:
URL: https://github.com/apache/pinot/pull/8112#discussion_r798161715



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java
##########
@@ -105,9 +106,11 @@ public static InstanceAssignmentConfig getInstanceAssignmentConfig(TableConfig t
     int numReplicaGroups = segmentConfig.getReplicationNumber();
     ReplicaGroupStrategyConfig replicaGroupStrategyConfig = segmentConfig.getReplicaGroupStrategyConfig();
     Preconditions.checkState(replicaGroupStrategyConfig != null, "Failed to find the replica-group strategy config");
+    SegmentPartitionConfig segmentPartitionConfig = tableConfig.getIndexingConfig().getSegmentPartitionConfig();

Review comment:
       So for tables which have legacy replica group assignment strategy configured, instance assignment will fail if they don't set partition config ? 
   
   Our tooling that creates the actual table config hasn't yet migrated to new InstanceAssignmentReplicaGroupConfig. So, with this change it looks like we will fail do instance assignment for any non-partitioned replica group based table (new at the time of table creation) or existing table if rebalancer is invoked with reassignInstances=true
   
   `Preconditions.checkState(segmentPartitionConfig != null, "Failed to find the segment partition config");` -> this is a breaking change. Why are we doing this ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org