You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/09 22:36:02 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #23970:
[SPARK-27054][BUILD][SQL] Remove the Calcite dependency
dongjoon-hyun commented on a change in pull request #23970: [SPARK-27054][BUILD][SQL] Remove the Calcite dependency
URL: https://github.com/apache/spark/pull/23970#discussion_r264017139
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala
##########
@@ -51,39 +52,57 @@ package object client {
// and fails.
case object v1_1 extends HiveVersion("1.1.0",
exclusions = Seq("eigenbase:eigenbase-properties",
+ "org.apache.calcite:calcite-core",
+ "org.apache.calcite:calcite-avatica",
"org.apache.curator:*",
"org.pentaho:pentaho-aggdesigner-algorithm",
"net.hydromatic:linq4j",
"net.hydromatic:quidem"))
case object v1_2 extends HiveVersion("1.2.2",
exclusions = Seq("eigenbase:eigenbase-properties",
+ "org.apache.calcite:calcite-core",
+ "org.apache.calcite:calcite-avatica",
"org.apache.curator:*",
"org.pentaho:pentaho-aggdesigner-algorithm",
"net.hydromatic:linq4j",
"net.hydromatic:quidem"))
case object v2_0 extends HiveVersion("2.0.1",
- exclusions = Seq("org.apache.curator:*",
+ exclusions = Seq("org.apache.calcite:calcite-core",
+ "org.apache.calcite:calcite-avatica",
+ "org.apache.curator:*",
"org.pentaho:pentaho-aggdesigner-algorithm"))
case object v2_1 extends HiveVersion("2.1.1",
- exclusions = Seq("org.apache.curator:*",
+ exclusions = Seq("org.apache.calcite:calcite-core",
+ "org.apache.calcite:calcite-avatica",
+ "org.apache.curator:*",
"org.pentaho:pentaho-aggdesigner-algorithm"))
case object v2_2 extends HiveVersion("2.2.0",
- exclusions = Seq("org.apache.curator:*",
+ exclusions = Seq("org.apache.calcite:calcite-core",
+ "org.apache.calcite:calcite-druid",
+ "org.apache.calcite.avatica:avatica",
+ "org.apache.curator:*",
"org.pentaho:pentaho-aggdesigner-algorithm"))
+ // Since HIVE-14496, Hive materialized view need calcite-core.
Review comment:
SPARK-27078 handles the Hive materialized view with `AnalysisException` gracefully. According to the test result, we are still keep the behavior, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org