You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@burr.apache.org by "Mr-Ruben (via GitHub)" <gi...@apache.org> on 2025/06/20 19:41:09 UTC

[PR] Update serde.rst [burr]

Mr-Ruben opened a new pull request, #555:
URL: https://github.com/apache/burr/pull/555

   As agreed here
   https://github.com/apache/burr/issues/554
   it would be helpful to mention some limitations/caveats.
   
   I leave it to you how you want to express it.
   
   Apologies if this is not the PR you were expecting. I don't know better.
   
   ------
   
   ## Changes
   
   ## How I tested this
   
   ## Notes
   
   ## Checklist
   
   - [ ] PR has an informative and human-readable title (this will be pulled into the release notes)
   - [ ] Changes are limited to a single goal (no scope creep)
   - [ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
   - [ ] Any _change_ in functionality is tested
   - [ ] New functions are documented (with a description, list of inputs, and expected output)
   - [ ] Placeholder code is flagged / future TODOs are captured in comments
   - [ ] Project documentation has been updated if adding/changing functionality.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update serde.rst [burr]

Posted by "Mr-Ruben (via GitHub)" <gi...@apache.org>.

Mr-Ruben commented on PR #555:
URL: https://github.com/apache/burr/pull/555#issuecomment-2993448764

   Additionally ...
   
   I have noticed Burr has good 'early errors detection' like "you are doing ... but you haven't done ..."
   
   You may consider adding 2 more:
   - If State has been / is being 'touched' by `@serde.serialize.register(State)` ->  say something
   - If the class passed on `.with_typing(PydanticTypingSystem(ApplicationState))` has been 'touched' by `@serde.serialize.register(cls)` -> say something


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update serde.rst [burr]

Posted by "skrawcz (via GitHub)" <gi...@apache.org>.

skrawcz commented on PR #555:
URL: https://github.com/apache/burr/pull/555#issuecomment-2993356108

   @Mr-Ruben it doesn't appear that you added anything? It is the right file that was touched, but there's no actual content committed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update serde.rst [burr]

Posted by "skrawcz (via GitHub)" <gi...@apache.org>.

skrawcz merged PR #555:
URL: https://github.com/apache/burr/pull/555


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org