You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org> on 2023/11/28 17:17:31 UTC
[PR] FINERACT-1724: Savings account block transaction with Account Number [fineract]
josehernandezfintecheandomx opened a new pull request, #3608:
URL: https://github.com/apache/fineract/pull/3608
## Description
Savings account block credit or debit transaction with Account Number instead of Account Id to be more descriptive
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1724: Savings account block transaction with Account Number [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3608:
URL: https://github.com/apache/fineract/pull/3608#discussion_r1409135147
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3713,14 +3713,14 @@ public Integer getSubStatus() {
public void validateForAccountBlock() {
final SavingsAccountSubStatusEnum currentSubStatus = SavingsAccountSubStatusEnum.fromInt(this.getSubStatus());
if (SavingsAccountSubStatusEnum.BLOCK.hasStateOf(currentSubStatus)) {
- throw new SavingsAccountBlockedException(this.getId());
+ throw new SavingsAccountBlockedException(getAccountNumber());
Review Comment:
Also please dont forget to add proper testing which validate your changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1724: Savings account block transaction with Account Number [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3608: FINERACT-1724: Savings account block transaction with Account Number
URL: https://github.com/apache/fineract/pull/3608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1724: Savings account block transaction with Account Number [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3608:
URL: https://github.com/apache/fineract/pull/3608#issuecomment-1885967472
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1724: Savings account block transaction with Account Number [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3608:
URL: https://github.com/apache/fineract/pull/3608#issuecomment-1849662259
@josehernandezfintecheandomx please dont forget to add proper testing which validate your changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1724: Savings account block transaction with Account Number [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3608:
URL: https://github.com/apache/fineract/pull/3608#discussion_r1409123154
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3713,14 +3713,14 @@ public Integer getSubStatus() {
public void validateForAccountBlock() {
final SavingsAccountSubStatusEnum currentSubStatus = SavingsAccountSubStatusEnum.fromInt(this.getSubStatus());
if (SavingsAccountSubStatusEnum.BLOCK.hasStateOf(currentSubStatus)) {
- throw new SavingsAccountBlockedException(this.getId());
+ throw new SavingsAccountBlockedException(getAccountNumber());
Review Comment:
This looks to me a breaking change.
Also I have checked and none of the other exceptions are using the account number! all of them using the account id instead…
What is the business need behind this change?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3713,14 +3713,14 @@ public Integer getSubStatus() {
public void validateForAccountBlock() {
final SavingsAccountSubStatusEnum currentSubStatus = SavingsAccountSubStatusEnum.fromInt(this.getSubStatus());
if (SavingsAccountSubStatusEnum.BLOCK.hasStateOf(currentSubStatus)) {
- throw new SavingsAccountBlockedException(this.getId());
+ throw new SavingsAccountBlockedException(getAccountNumber());
Review Comment:
This looks to me a breaking change.
Also I have checked and none of the other exceptions are using the account number! all of them using the account id instead…
What is the business need behind this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1724: Savings account block transaction with Account Number [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3608:
URL: https://github.com/apache/fineract/pull/3608#discussion_r1409133559
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3713,14 +3713,14 @@ public Integer getSubStatus() {
public void validateForAccountBlock() {
final SavingsAccountSubStatusEnum currentSubStatus = SavingsAccountSubStatusEnum.fromInt(this.getSubStatus());
if (SavingsAccountSubStatusEnum.BLOCK.hasStateOf(currentSubStatus)) {
- throw new SavingsAccountBlockedException(this.getId());
+ throw new SavingsAccountBlockedException(getAccountNumber());
Review Comment:
Please extend the parameters list with the account number instead of overriding the account id. There might be consumers who built logic on top of the parameters list of this exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org