You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/05/29 10:49:23 UTC
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284673#comment-13284673 ]
Hadoop QA commented on HADOOP-8434:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12529853/HADOOP-8434.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1045//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1045//console
This message is automatically generated.
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira