You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2015/08/27 22:25:10 UTC

svn commit: r1698227 - /lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/ReturnFieldsTest.java

Author: hossman
Date: Thu Aug 27 20:25:09 2015
New Revision: 1698227

URL: http://svn.apache.org/r1698227
Log:
LUCENE-6760: if the list of whitspace characters changes again in a future JVM, fail fast with a clear error that the test needs corrected -- even if jvm assertions are disabled OR we get really lucky with the chars radnomly selected

Modified:
    lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/ReturnFieldsTest.java

Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/ReturnFieldsTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/ReturnFieldsTest.java?rev=1698227&r1=1698226&r2=1698227&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/ReturnFieldsTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/ReturnFieldsTest.java Thu Aug 27 20:25:09 2015
@@ -385,6 +385,19 @@ public class ReturnFieldsTest extends So
     '\u205F',
     '\u3000',
   };
+
+  static {
+    // if the JVM/unicode can redefine whitespace once (LUCENE-6760), it might happen again
+    // in the future.  if that happens, fail early with a clera msg, even if java asserts
+    // (used in randomWhitespace) are disbled
+    
+    for (int offset = 0; offset < WHITESPACE_CHARACTERS.length; offset++) {
+      char c = WHITESPACE_CHARACTERS[offset];
+      if (! Character.isWhitespace(c) ) {
+        fail(String.format(Locale.ENGLISH, "Not really whitespace? New JVM/Unicode definitions? WHITESPACE_CHARACTERS[%d] is '\\u%04X'", offset, (int) c));
+      }
+    }
+  }
   
   /**
    * Returns a random string in the specified length range consisting