[jira] [Commented] (BEAM-13672) Window.into() without a windowFn not correctly translated to portable representation

["Kenneth Knowles (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479557#comment-17479557 ] 

Kenneth Knowles commented on BEAM-13672:
----------------------------------------

The PCollection should be translated to proto directly, and the allowed lateness is a property of the windowing strategy on the PCollection. That is why it is expanded in the way that it is. I trust that you encountered this in the wild, so I am curious if it is easy to reproduce in a small test.

> Window.into() without a windowFn not correctly translated to portable representation
> ------------------------------------------------------------------------------------
>
>                 Key: BEAM-13672
>                 URL: https://issues.apache.org/jira/browse/BEAM-13672
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.35.0
>            Reporter: Steve Niemitz
>            Priority: P1
>
> On the "classic" non-portable runner, you can do something like:
> {{Window.configure().discardingFiredPanes().withAllowedLateness(maxFinalJitter)}}
> to configure the max allowed lateness on a PCollection.  This translates into a Flatten transform [1].  It doesn't seem like the FlattenTranslator uses this information anywhere [2], and the result is that the configuration is lost when translating to a portable pipeline.
> [1] [https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java#L403]
>  
> [2] https://github.com/apache/beam/blob/master/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/FlattenTranslator.java#L53



--
This message was sent by Atlassian Jira
(v8.20.1#820001)