[GitHub] [ozone] kerneltime commented on a diff in pull request #4228: HDDS-7859. ICR processing does not remove container reference in NodeManager for a deleted replica

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #4228:
URL: https://github.com/apache/ozone/pull/4228#discussion_r1092842733


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/IncrementalContainerReportHandler.java:
##########
@@ -91,6 +91,8 @@ public void onMessage(final IncrementalContainerReportFromDatanode report,
             if (!replicaProto.getState().equals(
                 ContainerReplicaProto.State.DELETED)) {
               nodeManager.addContainer(dd, id);
+            } else {

Review Comment:
   Should we check for `replicaProto.getState().equals(ContainerReplicaProto.State.DELETED)` to remove the container?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org