You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/28 15:56:52 UTC
[GitHub] [spark] srowen commented on issue #24727: [SPARK-27867][ML]
RegressionEvaluator cache lastest RegressionMetrics to avoid duplicated
computation
srowen commented on issue #24727: [SPARK-27867][ML] RegressionEvaluator cache lastest RegressionMetrics to avoid duplicated computation
URL: https://github.com/apache/spark/pull/24727#issuecomment-496578456
I don't quite agree with this. If the caller has evaluated the metrics on a Dataset, and the Dataset hasn't changed, the caller doesn't need to call this at all. The caller knows that, though. I don't think the extra state and complexity in here is worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org