[GitHub] brooklyn-server pull request #488: Get ready for compiling with JDK 1.8 / Ja...

[googlielmo <gi...@git.apache.org>]

Github user googlielmo commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/488#discussion_r92364968
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java ---
    @@ -486,8 +486,8 @@ public DslConfigSupplier(DslComponent component, String keyName) {
                 if (targetEntityMaybe.isAbsent()) return Maybe.absent("Target entity not available");
                 EntityInternal targetEntity = (EntityInternal) targetEntityMaybe.get();
     
    -            ConfigKey<?> key = targetEntity.getEntityType().getConfigKey(keyName);
    -            Maybe<? extends Object> result = targetEntity.config().getNonBlocking(key != null ? key : ConfigKeys.newConfigKey(Object.class, keyName));
    +            ConfigKey key = targetEntity.getEntityType().getConfigKey(keyName);
    --- End diff --
    
    @aledsage I agree in principle.
    In this particular case, as Java 8 has a deeper / more precise type inference algorithm, it refuses to compile, because it cannot guarantee that the type of the Maybe (the capture of ?) is actually compatible with both the `key` and the `newConfigKey` call. I wonder how it could be permitted in java 7, actually :-)
    I will reinstate the generics with Object as that's the only type that's accepted unequivocally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---