You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/03/22 21:33:59 UTC
Review Request 45178: Revert "Add support for storing and fetching
images as properties of task configs."
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45178/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1648
https://issues.apache.org/jira/browse/AURORA-1648
Repository: aurora
Description
-------
This reverts commit d5d7ec0eb5703d6bda8c43cd0586684a550a575a. As outlined in `AURORA-1648` the schema changes here are not necessarily reflected in H2 after a restore from backup.
Diffs
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 98064bb4607e9fbdff71eaceb2784f407fe91108
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java c6785d0a997dde0783384ccaa7e241d32e1dd898
src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 25160df1be9539c1ecd4613db5deb99a9606a512
src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java e778a39ef61e456ad9d2d2aa6f3e5d69e44bf02c
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java 5964a2a0b1f602eda0f8f2a8f31a2f15d93dcca7
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java cdd1060401a38e26cd726ec95e2bb617ccf4708c
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml cfeb69ba65875831f88ea94b791214391991b3b8
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 92a0798d4d97920b786c4713f8779a7a32767652
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 52e97080760a70f8e003b1cc7fc0fbeb2ec6d689
src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 2343394a34541bc266f74b5da512cda6f8e6b56a
src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 8a87ff6445ab83aea144867d029537f86c7b61d7
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java e43ec6cb35cbb454b967238dfb9ce006b21f4fb6
Diff: https://reviews.apache.org/r/45178/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 45178: Revert "Add support for storing and fetching
images as properties of task configs."
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45178/#review124880
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On March 22, 2016, 8:33 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45178/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 8:33 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1648
> https://issues.apache.org/jira/browse/AURORA-1648
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This reverts commit d5d7ec0eb5703d6bda8c43cd0586684a550a575a. As outlined in `AURORA-1648` the schema changes here are not necessarily reflected in H2 after a restore from backup.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 98064bb4607e9fbdff71eaceb2784f407fe91108
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java c6785d0a997dde0783384ccaa7e241d32e1dd898
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 25160df1be9539c1ecd4613db5deb99a9606a512
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java e778a39ef61e456ad9d2d2aa6f3e5d69e44bf02c
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java 5964a2a0b1f602eda0f8f2a8f31a2f15d93dcca7
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java cdd1060401a38e26cd726ec95e2bb617ccf4708c
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml cfeb69ba65875831f88ea94b791214391991b3b8
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 92a0798d4d97920b786c4713f8779a7a32767652
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 52e97080760a70f8e003b1cc7fc0fbeb2ec6d689
> src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 2343394a34541bc266f74b5da512cda6f8e6b56a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 8a87ff6445ab83aea144867d029537f86c7b61d7
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java e43ec6cb35cbb454b967238dfb9ce006b21f4fb6
>
> Diff: https://reviews.apache.org/r/45178/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>