[jira] [Commented] (NIFI-2802) The implementation classes don't support orderByClause.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512821#comment-15512821 ] 

ASF GitHub Bot commented on NIFI-2802:
--------------------------------------

GitHub user combineads opened a pull request:

    https://github.com/apache/nifi/pull/1044

    NIFI-2802 The implementation classes don't support orderByClause.

    The implementation classes don't support orderByClause.
    The below code is the part of GenericDatabaseAdapter class(even OracleDatabaseAdapter and DerbyDatabaseAdapter).
    
    if (!StringUtils.isEmpty(orderByClause)) {
     query.append(" ORDER BY "); query.append(whereClause);
    }
    
    Expected:
    if (!StringUtils.isEmpty(orderByClause)) {
     query.append(" ORDER BY "); query.append(orderByClause);
    }

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/combineads/nifi NIFI-2802

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1044
    
----

----


> The implementation classes don't support orderByClause.
> -------------------------------------------------------
>
>                 Key: NIFI-2802
>                 URL: https://issues.apache.org/jira/browse/NIFI-2802
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.0.0
>            Reporter: Byunghwa Yun
>            Priority: Minor
>
> The implementation classes don't support orderByClause.
> The below code is the part of GenericDatabaseAdapter class(even OracleDatabaseAdapter and DerbyDatabaseAdapter).
>         if (!StringUtils.isEmpty(orderByClause)) {
>             query.append(" ORDER BY ");
>             query.append(whereClause);
>         }
> Expected:
>         if (!StringUtils.isEmpty(orderByClause)) {
>             query.append(" ORDER BY ");
>             query.append(orderByClause);
>         }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)