You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Peter Samuelson <pe...@p12n.org> on 2008/02/22 01:07:53 UTC
[PATCH] Re: svn commit: r29493
[epg@tigris.org]
> Log:
> Don't try to load DSOs unless configured with --enable-loadable-ra-modules.
Someone forgot to change --enable-dso to --enable-loadable-ra-modules -
only the help text was changed, not the option. Also, wasn't there
talk of renaming it to --enable-loadable-modules, since it's also about
FS modules now?
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[[[
* configure.ac (--enable-dso): Rename to --enable-loadable-modules;
update help text to mention both RA and FS modules. The internal
state variable is still $enable_dso.
]]]
Index: configure.ac
===================================================================
--- configure.ac (revisione 29494)
+++ configure.ac (copia locale)
@@ -592,15 +592,15 @@
SVN_CHECK_SWIG
-dnl decide whether we want to link against the RA libraries
-AC_ARG_ENABLE(dso,
-AS_HELP_STRING([--enable-loadable-ra-modules],
- [Turn on DSO loading of RA libraries]),
+dnl decide whether to link to RA / FS modules, or to load them at runtime
+AC_ARG_ENABLE(loadable-modules,
+AS_HELP_STRING([--enable-loadable-modules],
+ [Turn on DSO loading of RA and FS libraries]),
[
if test "$enableval" = "yes"; then
enable_dso=yes
if test "$enable_shared" = "no"; then
- AC_MSG_ERROR([--enable-loadable-ra-modules conflicts with --disable-shared])
+ AC_MSG_ERROR([--enable-loadable-modules conflicts with --disable-shared])
fi
AC_DEFINE(SVN_USE_DSO, 1,
[Defined if svn should try to load DSOs])
Re: [PATCH] Re: svn commit: r29493
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Thu, Feb 21, 2008 at 5:16 PM, David Glasser <gl...@davidglasser.net> wrote:
> Bikeshedding, but the term "loadable" is so vague. Why not
> --enable-runtime-module-search?
Fixed the argument and renamed it to your bikeshed color in r29553.
=) -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: svn commit: r29493
Posted by David Glasser <gl...@davidglasser.net>.
Bikeshedding, but the term "loadable" is so vague. Why not
--enable-runtime-module-search?
--dave
On Thu, Feb 21, 2008 at 8:07 PM, Peter Samuelson <pe...@p12n.org> wrote:
>
> [epg@tigris.org]
> > Log:
> > Don't try to load DSOs unless configured with --enable-loadable-ra-modules.
>
> Someone forgot to change --enable-dso to --enable-loadable-ra-modules -
> only the help text was changed, not the option. Also, wasn't there
> talk of renaming it to --enable-loadable-modules, since it's also about
> FS modules now?
> --
> Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
>
> [[[
> * configure.ac (--enable-dso): Rename to --enable-loadable-modules;
> update help text to mention both RA and FS modules. The internal
> state variable is still $enable_dso.
> ]]]
>
> Index: configure.ac
> ===================================================================
> --- configure.ac (revisione 29494)
> +++ configure.ac (copia locale)
> @@ -592,15 +592,15 @@
>
> SVN_CHECK_SWIG
>
> -dnl decide whether we want to link against the RA libraries
> -AC_ARG_ENABLE(dso,
> -AS_HELP_STRING([--enable-loadable-ra-modules],
> - [Turn on DSO loading of RA libraries]),
> +dnl decide whether to link to RA / FS modules, or to load them at runtime
> +AC_ARG_ENABLE(loadable-modules,
> +AS_HELP_STRING([--enable-loadable-modules],
> + [Turn on DSO loading of RA and FS libraries]),
> [
> if test "$enableval" = "yes"; then
> enable_dso=yes
> if test "$enable_shared" = "no"; then
> - AC_MSG_ERROR([--enable-loadable-ra-modules conflicts with --disable-shared])
> + AC_MSG_ERROR([--enable-loadable-modules conflicts with --disable-shared])
> fi
> AC_DEFINE(SVN_USE_DSO, 1,
> [Defined if svn should try to load DSOs])
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHviBoXk7sIRPQRh0RAsN9AJ9fQOS+Unu4jUoNrLYswB2PpLwPtwCcDlfO
> nGbtG83BPzbnaKLDAwjDH7w=
> =ZJMy
> -----END PGP SIGNATURE-----
>
>
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org