You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/25 02:56:29 UTC
[GitHub] [flink] yuzelin opened a new pull request, #21141: [FLINK-29742] Support completing statement in SqlGatewayService.
yuzelin opened a new pull request, #21141:
URL: https://github.com/apache/flink/pull/21141
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 merged pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
fsk119 merged PR #21141:
URL: https://github.com/apache/flink/pull/21141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21141:
URL: https://github.com/apache/flink/pull/21141#issuecomment-1289913250
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "45299902af8abdcc2da247f590416cf657cb9988",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45299902af8abdcc2da247f590416cf657cb9988",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45299902af8abdcc2da247f590416cf657cb9988 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on a diff in pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
fsk119 commented on code in PR #21141:
URL: https://github.com/apache/flink/pull/21141#discussion_r1030264916
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java:
##########
@@ -311,6 +312,13 @@ public GatewayInfo getGatewayInfo() {
return GatewayInfo.INSTANCE;
}
+ @Override
+ public List<String> completeStatement(
+ SessionHandle sessionHandle, String statement, int position)
+ throws SqlGatewayException {
+ return getSession(sessionHandle).createExecutor().getCompletionHints(statement, position);
Review Comment:
I think the completeStatement should be thread-safe and we should translate to operation and let the OperaitonManager to fire the execution. The reason behind is the `SqlAdvisor` will visit the `CatalogManager` that is not thread-safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuzelin commented on a diff in pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
yuzelin commented on code in PR #21141:
URL: https://github.com/apache/flink/pull/21141#discussion_r1044272601
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java:
##########
@@ -554,6 +554,55 @@ public void testListUserDefinedFunctions() {
"table_func0"))));
}
+ @Test
+ public void testCompleteStatement() throws Exception {
+ SessionHandle sessionHandle = service.openSession(defaultSessionEnvironment);
+
+ String createTable1 =
+ "CREATE TABLE Table1 (\n"
+ + " IntegerField1 INT,\n"
+ + " StringField1 STRING,\n"
+ + " TimestampField1 TIMESTAMP(3)\n"
+ + ") WITH (\n"
+ + " 'connector' = 'datagen'\n"
+ + ")\n";
+ String createTable2 =
+ "CREATE TABLE Table2 (\n"
+ + " BooleanField BOOLEAN,\n"
+ + " StringField2 STRING,\n"
+ + " TimestampField2 TIMESTAMP\n"
+ + ") WITH (\n"
+ + " 'connector' = 'blackhole'\n"
+ + ")\n";
+
+ service.getSession(sessionHandle)
+ .createExecutor()
+ .getTableEnvironment()
+ .executeSql(createTable1);
+ service.getSession(sessionHandle)
+ .createExecutor()
+ .getTableEnvironment()
+ .executeSql(createTable2);
+
+ List<String> expectedTableHints =
+ Arrays.asList(
+ "default_catalog.default_database.Table1",
+ "default_catalog.default_database.Table2");
+ String incompleteSql = "SELECT * FROM Ta";
Review Comment:
Improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuzelin commented on pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
yuzelin commented on PR #21141:
URL: https://github.com/apache/flink/pull/21141#issuecomment-1293521722
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuzelin commented on pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
yuzelin commented on PR #21141:
URL: https://github.com/apache/flink/pull/21141#issuecomment-1293294800
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on a diff in pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
fsk119 commented on code in PR #21141:
URL: https://github.com/apache/flink/pull/21141#discussion_r1044047364
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java:
##########
@@ -554,6 +554,55 @@ public void testListUserDefinedFunctions() {
"table_func0"))));
}
+ @Test
+ public void testCompleteStatement() throws Exception {
+ SessionHandle sessionHandle = service.openSession(defaultSessionEnvironment);
+
+ String createTable1 =
+ "CREATE TABLE Table1 (\n"
+ + " IntegerField1 INT,\n"
+ + " StringField1 STRING,\n"
+ + " TimestampField1 TIMESTAMP(3)\n"
+ + ") WITH (\n"
+ + " 'connector' = 'datagen'\n"
+ + ")\n";
+ String createTable2 =
+ "CREATE TABLE Table2 (\n"
+ + " BooleanField BOOLEAN,\n"
+ + " StringField2 STRING,\n"
+ + " TimestampField2 TIMESTAMP\n"
+ + ") WITH (\n"
+ + " 'connector' = 'blackhole'\n"
+ + ")\n";
+
+ service.getSession(sessionHandle)
+ .createExecutor()
+ .getTableEnvironment()
+ .executeSql(createTable1);
+ service.getSession(sessionHandle)
+ .createExecutor()
+ .getTableEnvironment()
+ .executeSql(createTable2);
+
+ List<String> expectedTableHints =
+ Arrays.asList(
+ "default_catalog.default_database.Table1",
+ "default_catalog.default_database.Table2");
+ String incompleteSql = "SELECT * FROM Ta";
Review Comment:
I think we can inline incompleteSql and expectedTableHints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuzelin commented on pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.
Posted by GitBox <gi...@apache.org>.
yuzelin commented on PR #21141:
URL: https://github.com/apache/flink/pull/21141#issuecomment-1308290084
cc @fsk119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org